Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-3083: updated default php version to 8.3 for cs-wizard command #1811

Closed
wants to merge 2 commits into from
Closed

GL-3083: updated default php version to 8.3 for cs-wizard command #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
373ca79
GL-3083: cs-wizard updated default php version to 8.3
PrakharJainS3 Oct 14, 2024
50d123d
CLI-1400: Exclude disk space exhaustion errors (#1809)
danepowell Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Command/CodeStudio/CodeStudioWizardCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
'PHP_version_8.2' => "8.2",
'PHP_version_8.3' => "8.3",
];
$project = $this->io->choice('Select a PHP version', array_values($phpVersions), "8.1");
$project = $this->io->choice('Select a PHP version', array_values($phpVersions), "8.3");
$project = array_search($project, $phpVersions, true);
$phpVersion = $phpVersions[$project];
break;
Expand Down
2 changes: 2 additions & 0 deletions src/Helpers/TelemetryHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@
case str_starts_with($report->getMessage(), 'Allowed memory size'):
// Exclude i/o errors.
case str_starts_with($report->getMessage(), 'fgets'):
// Exclude exhausted disk space.
case str_starts_with($report->getMessage(), 'fwrite'):

Check warning on line 60 in src/Helpers/TelemetryHelper.php

View check run for this annotation

Codecov / codecov/patch

src/Helpers/TelemetryHelper.php#L60 

Added line #L60 was not covered by tests
return false;
}
// Set user info.
Expand Down
Loading