Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1402: [push:db] Warn if view database connection details permission is missing #1810

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Oct 10, 2024

Motivation

Fixes CLI-1402

Proposed changes

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Create a Cloud API user lacking the permission to view connection details.
  4. Run acli pull:db (optionally include --no-import so you don't need a local DB), see that it runs successfully.
  5. Run acli push:db, see that you get a graceful exception with details about the permission required.
  6. Give yourself the permission.
  7. Run acli push:db again and see that it runs successfully.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (1ffc996) to head (4bdb647).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1810   +/-   ##
=========================================
  Coverage     92.75%   92.76%           
- Complexity     1819     1822    +3     
=========================================
  Files           122      122           
  Lines          6905     6912    +7     
=========================================
+ Hits           6405     6412    +7     
  Misses          500      500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1810/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1810/acli.phar
chmod +x acli.phar

@danepowell danepowell marked this pull request as ready for review October 16, 2024 22:27
@danepowell danepowell changed the title CLI-1402: Warn if view database connection details permission is missing CLI-1402: [push:db] Warn if view database connection details permission is missing Oct 17, 2024
@danepowell danepowell merged commit 1dba2de into acquia:main Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants