Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1397: Exception on local non-RSA SSH keys #1802

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes CLI-1397

Proposed changes

Remove the check for RSA keys

It looks like this was added in #1501 because we simply copied the code from the upstream library: https://github.com/violuke/rsa-ssh-key-fingerprint/blob/master/src/violuke/RsaSshKeyFingerprint/FingerprintGenerator.php

But I can't see any reason to restrict that code to RSA keys. You can run sha256 on any key 🤷

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

@danepowell danepowell added the bug Something isn't working label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (6482891) to head (c3671ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1802      +/-   ##
============================================
+ Coverage     92.23%   92.24%   +0.01%     
+ Complexity     1818     1817       -1     
============================================
  Files           121      121              
  Lines          6825     6823       -2     
============================================
- Hits           6295     6294       -1     
+ Misses          530      529       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell
Copy link
Contributor Author

Test failure is unrelated

@danepowell danepowell merged commit fa517ff into acquia:main Sep 20, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant