CLI-1397: Exception on local non-RSA SSH keys #1802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes CLI-1397
Proposed changes
Remove the check for RSA keys
It looks like this was added in #1501 because we simply copied the code from the upstream library: https://github.com/violuke/rsa-ssh-key-fingerprint/blob/master/src/violuke/RsaSshKeyFingerprint/FingerprintGenerator.php
But I can't see any reason to restrict that code to RSA keys. You can run sha256 on any key 🤷
Alternatives considered
Testing steps
./bin/acli ckc