Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1380: Stop reporting memory exhaustion #1785

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes CLI-1380

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.21%. Comparing base (a700f92) to head (881f69a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Helpers/TelemetryHelper.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1785   +/-   ##
=========================================
  Coverage     92.21%   92.21%           
  Complexity     1817     1817           
=========================================
  Files           121      121           
  Lines          6811     6811           
=========================================
  Hits           6281     6281           
  Misses          530      530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1785/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1785/acli.phar
chmod +x acli.phar

@danepowell danepowell merged commit 5451922 into acquia:main Aug 30, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant