Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-2582 : Remove schedule pipelines for node projects #1759

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

akashkska
Copy link
Contributor

@akashkska akashkska commented Jun 26, 2024

As of now schedule pipelines are configured for both node projects and drupal projects. But those are only required for Drupal Projects. Hence removing it from node projects.

Manual tests:

  1. With the Node project selected in the cs:wizard command, the resultant Node project in Gitlab should not have a pre-configured scheduled pipeline
  2. Regression test: With this update, the Drupal selection flow should not be impacted (i.e. creation, variables etc. along with a configured scheduled pipeline should be validated)

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (5a4966d) to head (6f4d898).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1759   +/-   ##
=========================================
  Coverage     91.75%   91.75%           
  Complexity     1818     1818           
=========================================
  Files           121      121           
  Lines          6524     6524           
=========================================
  Hits           5986     5986           
  Misses          538      538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1759/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1759/acli.phar
chmod +x acli.phar

@shriacquia shriacquia added the bug Something isn't working label Jun 26, 2024
@danepowell danepowell enabled auto-merge (squash) June 26, 2024 18:49
@danepowell danepowell merged commit 4eb854b into acquia:main Jun 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants