-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track environment provider in telemetry. #1741
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
============================================
+ Coverage 91.70% 91.73% +0.02%
- Complexity 1805 1810 +5
============================================
Files 121 121
Lines 6474 6506 +32
============================================
+ Hits 5937 5968 +31
- Misses 537 538 +1 ☔ View full report in Codecov by Sentry. |
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1741/acli.phar
|
Looks like there are no automated tests for the TelemetryHelper at present. Also, I don't see how Amplitude ever gets initialized in local environments, because it only gets initialized when AMPLITUDE_KEY is set via an environmental variable. How does this work for Lando and DDEV usage? Other way to implement this would be to add it to event properties rather than user properties, like here: cli/src/Command/CommandBase.php Line 254 in 50fdfff
But, we're already tracking ah_env as a user property. Not sure why that's not part of the event properties instead. Probably not great to change now because it would mess up historical data trends. |
Ok, not sure why the mutation testing is failing. I tried to appease it, but to no avail. |
Motivation
We often don't know if ACLI is running in Code Studio, on local, or elsewhere.
Proposed changes
Add an "env_provider" data point to telemetry, based on env variables, to determine env provider.