CLI-1330: TypeError for SSH commands on Node environments #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1734/acli.phar |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
============================================
+ Coverage 91.64% 91.66% +0.01%
- Complexity 1808 1812 +4
============================================
Files 121 121
Lines 6475 6476 +1
============================================
+ Hits 5934 5936 +2
+ Misses 541 540 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really only the tip of the iceberg. There are entire categories of command (anything involving SSH) that can't be run on Node hosting environments. We should restrict those somehow, but that's beyond the scope of this ticket.