GL-1723: Added expires_at mandatory arg for codestudio token. #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
=========================================
Coverage 91.84% 91.84%
Complexity 1819 1819
=========================================
Files 124 124
Lines 6513 6514 +1
=========================================
+ Hits 5982 5983 +1
Misses 531 531
☔ View full report in Codecov by Sentry. |
danepowell
requested changes
Oct 30, 2023
|
Hi @danepowell I don't see option to add label to this PR due to which one check is failing. This was breaking change for codestudio. will you please help us to add label and merge this PR in main. |
danepowell
reviewed
Oct 31, 2023
| @@ -161,8 +161,10 @@ private function createProjectAccessToken(array $project, string $projectAccessT | |||
| $this->checklist->completePreviousItem(); | |||
| } | |||
| $this->checklist->addItem("Creating access token named <comment>$projectAccessTokenName</comment>"); | |||
| $dateTime = new \DateTime('tomorrow'); | |||
There was a problem hiding this comment.
This token needs to be long-lived since it's going to be stored as a CI/CD variable, right? Should we max out the lifetime (1 year)?
|
I'm going to go ahead and merge this. If you think the expiry time or anything else needs to be adjusted, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to create personal access tokens without expiry was deprecated in GitLab 15.4 and removed in GitLab 16.0. In GitLab 16.0 and later, existing personal access tokens without an expiry date are automatically given an expiry date of 365 days.
Codestudio main branch is upgraded with gitlab 16.x version. hence this is breaking change.
An optional variable in previous version https://archives.docs.gitlab.com/15.11/ee/api/project_access_tokens.html#create-a-project-access-token become mandatory in 16.x.x + versions https://docs.gitlab.com/ee/api/project_access_tokens.html#create-a-project-access-token.
Solution: As a part this PR added mandatory arg
expires_atwith valid expiry date.