-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-1171: Home directory errors on Windows #1611
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
============================================
+ Coverage 91.68% 91.78% +0.09%
Complexity 1809 1809
============================================
Files 124 124
Lines 6485 6485
============================================
+ Hits 5946 5952 +6
+ Misses 539 533 -6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I added some test cases but I cannot push to your fork, and I want to make sure you get credit for this PR. Can you please cherry-pick this commit into your fork? c359286
Thanks @danepowell, I couldn't cherry pick from the fork you referenced (insufficient permissions) so transferred changes manually. If you want to keep your name on the commit - we can reverse it and you could commit to my fork, I added yo as a contributor to https://github.com/undp/acquia-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not picky. Looks good, thanks!
Motivation
Fixes #1610
Proposed changes
extending env variable testing condition to avoid PHP error when the var is not present
Alternatives considered
Testing steps
./bin/acli ckc