Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1171: Home directory errors on Windows #1611

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

Jura
Copy link
Contributor

@Jura Jura commented Oct 20, 2023

Motivation

Fixes #1610

Proposed changes

extending env variable testing condition to avoid PHP error when the var is not present

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

@github-actions github-actions bot added the bug Something isn't working label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fdac94) 91.68% compared to head (1bd01cb) 91.78%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1611      +/-   ##
============================================
+ Coverage     91.68%   91.78%   +0.09%     
  Complexity     1809     1809              
============================================
  Files           124      124              
  Lines          6485     6485              
============================================
+ Hits           5946     5952       +6     
+ Misses          539      533       -6     
Files Coverage Δ
src/Helpers/LocalMachineHelper.php 62.22% <100.00%> (+4.44%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@danepowell danepowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added some test cases but I cannot push to your fork, and I want to make sure you get credit for this PR. Can you please cherry-pick this commit into your fork? c359286

@Jura
Copy link
Contributor Author

Jura commented Oct 23, 2023

Thanks @danepowell, I couldn't cherry pick from the fork you referenced (insufficient permissions) so transferred changes manually. If you want to keep your name on the commit - we can reverse it and you could commit to my fork, I added yo as a contributor to https://github.com/undp/acquia-cli

Copy link
Contributor

@danepowell danepowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not picky. Looks good, thanks!

@danepowell danepowell changed the title CLI-1171: updated env variable testing condition CLI-1171: Home directory errors on Windows Oct 23, 2023
@danepowell danepowell enabled auto-merge (squash) October 23, 2023 21:51
@danepowell danepowell merged commit 030e53b into acquia:main Oct 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI-1171: acli throws error in Windows terminal
2 participants