Skip to content

Commit

Permalink
Set code studio default env variable values to be masked (#1586)
Browse files Browse the repository at this point in the history
* make default env value to be masked

* resolved mutants

* revert changes to verify mutation test

* verifying few things for mutation test

* final changes to set default env vaule to be masked

---------

Co-authored-by: Adam Balsam <[email protected]>
  • Loading branch information
shubham-bansal96 and balsama authored Sep 21, 2023
1 parent 471793e commit e317dab
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions src/Command/CodeStudio/CodeStudioCiCdVariables.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,28 +20,28 @@ public static function getDefaults(?string $cloudApplicationUuid = NULL, ?string
return [
[
'key' => 'ACQUIA_APPLICATION_UUID',
'masked' => FALSE,
'masked' => TRUE,
'protected' => FALSE,
'value' => $cloudApplicationUuid,
'variable_type' => 'env_var',
],
[
'key' => 'ACQUIA_CLOUD_API_TOKEN_KEY',
'masked' => FALSE,
'masked' => TRUE,
'protected' => FALSE,
'value' => $cloudKey,
'variable_type' => 'env_var',
],
[
'key' => 'ACQUIA_CLOUD_API_TOKEN_SECRET',
'masked' => FALSE,
'masked' => TRUE,
'protected' => FALSE,
'value' => $cloudSecret,
'variable_type' => 'env_var',
],
[
'key' => 'ACQUIA_GLAB_TOKEN_NAME',
'masked' => FALSE,
'masked' => TRUE,
'protected' => FALSE,
'value' => $projectAccessTokenName,
'variable_type' => 'env_var',
Expand Down
4 changes: 2 additions & 2 deletions tests/phpunit/src/CommandTestBase.php
Original file line number Diff line number Diff line change
Expand Up @@ -621,15 +621,15 @@ protected function getMockGitLabVariables(): array {
0 => [
'environment_scope' => '*',
'key' => 'ACQUIA_APPLICATION_UUID',
'masked' => FALSE,
'masked' => TRUE,
'protected' => FALSE,
'value' => '2b3f7cf0-6602-4590-948b-3b07b1b005ef',
'variable_type' => 'env_var',
],
1 => [
'environment_scope' => '*',
'key' => 'ACQUIA_CLOUD_API_TOKEN_KEY',
'masked' => FALSE,
'masked' => TRUE,
'protected' => FALSE,
'value' => '111aae74-e81a-4052-b4b9-a27a62e6b6a6',
'variable_type' => 'env_var',
Expand Down

0 comments on commit e317dab

Please sign in to comment.