Correctly set Phar path for self update. (#137)

src/Command/UpdateCommand.php

@@ -10,6 +10,7 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
+use Webmozart\PathUtil\Path;
 
 /**
  * Class UpdateCommand.
@@ -41,8 +42,7 @@ protected function commandRequiresAuthentication(): bool {
    */
   protected function execute(InputInterface $input, OutputInterface $output) {
     if (!$this->getPharPath()) {
-      throw new RuntimeException('update only works when running the phar version of ' . $this->getApplication()
-          ->getName() . '.');
+      throw new RuntimeException('update only works when running the phar version of ' . $this->getApplication()->getName() . '.');
     }
 
     $updater = new Updater($this->getPharPath(), FALSE);
@@ -73,7 +73,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
    */
   public function getPharPath(): string {
     if (!isset($this->pharPath)) {
-      $this->pharPath = Phar::running(TRUE);
+      $this->setPharPath(Phar::running(FALSE));
     }
     return $this->pharPath;
   }
@@ -82,7 +82,7 @@ public function getPharPath(): string {
    * @param string $pharPath
    */
   public function setPharPath(string $pharPath): void {
-    $this->pharPath = $pharPath;
+    $this->pharPath = Path::canonicalize($pharPath);
   }
 
 }

src/SelfUpdate/Strategy/GithubStrategy.php

@@ -1,20 +1,14 @@
 <?php
-/**
- * This class is partially patterned after Composer's self-update.
- */
 
 namespace Acquia\Cli\SelfUpdate\Strategy;
 
-use Acquia\Cli\Exception\AcquiaCliException;
 use Humbug\SelfUpdate\Exception\HttpRequestException;
 use Humbug\SelfUpdate\Exception\JsonParsingException;
-use Humbug\SelfUpdate\Strategy\StrategyInterface;
 use Humbug\SelfUpdate\Updater;
 use Humbug\SelfUpdate\VersionParser;
 
-class GithubStrategy extends \Humbug\SelfUpdate\Strategy\GithubStrategy implements StrategyInterface
-{
-  const API_URL = 'https://api.github.com/repos/%s/releases';
+class GithubStrategy extends \Humbug\SelfUpdate\Strategy\GithubStrategy {
+  public const API_URL = 'https://api.github.com/repos/%s/releases';
 
   /**
    * @var string

tests/phpunit/src/Commands/UpdateCommandTest.php

@@ -36,6 +36,7 @@ public function testNonPharException(): void {
 
   /**
    * @requires OS linux|darwin
+   * @throws \Exception
    */
   public function testDownloadUpdate(): void {