ipv6: rewrite core ipv6 methods to operate on u128s #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some assembly analysis and saw that the methods on
Ipv6Network
were not optimizing nearly as well as the equivalentIpv4Network
methods. This PR rewrites the core methods onIpv6Network
to useu128
similarly to howIpv4Network
usesu32
.While preforming this change I addressed some clippy lints and made some more common-sense additions.
Results on
.contains()
Before:
After: