-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vehicle Damage - Code cleanup #9831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnb432
changed the title
Vehicle damage - Improve multiple aspects
Vehicle damage - Code cleanup
Jun 29, 2024
johnb432
added
kind/optimization
Release Notes: **IMPROVED:**
and removed
kind/enhancement
Release Notes: **IMPROVED:**
labels
Jun 29, 2024
LinkIsGrim
reviewed
Aug 13, 2024
johnb432
commented
Aug 13, 2024
LinkIsGrim
reviewed
Aug 17, 2024
LinkIsGrim
reviewed
Aug 17, 2024
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
PabstMirror
reviewed
Aug 18, 2024
PabstMirror
approved these changes
Aug 18, 2024
Co-authored-by: PabstMirror <[email protected]>
LinkIsGrim
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
EGVAR(cookoff,canHaveFireJet) = 1;
to config, as the default was1
with[_configOf >> QEGVAR(cookoff,canHaveFireJet), "number", 1] call CBA_fnc_getConfigEntry
.CBA_fnc_getConfigEntry
is about 2-3x more performance intentsive than thegetX
config commands, so I switched over to thegetX
commands as much as possible.toLowerANSI
hitpoint aliases, which weren't guaranteed to be lowercase.FUNC(addDamage)
toFUNC(setDamage)
, as it doesn't add to existing damage, it sets it.This is ready for review, but it needs testing.I have tested it, behaves as it did previously.I haven't really touched the core logic of vehicle damage, so don't expect it to be magically fixed. With help, I am willing to redo some of the logic though.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.