Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artillery Tables - Add additional extension hooks for shot simulation and solution calculation #9298

Closed
wants to merge 5 commits into from

Conversation

LorenLuke
Copy link
Contributor

@LorenLuke LorenLuke commented Jul 28, 2023

When merged this pull request will:

  • Title.

To be used for a dedicated artillery computer.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Jul 29, 2023
@LinkIsGrim LinkIsGrim added this to the Ongoing milestone Jul 29, 2023
@LinkIsGrim LinkIsGrim changed the title Adds additional extension hooks for artillery simulation and solution finding Artillery Tables - Add additional extension hooks for shot simulation and solution calculation Jul 29, 2023
Fixes bug with getting max distance in extension.
Adds script functions for easier hooking.
@PabstMirror PabstMirror changed the title Artillery Tables - Add additional extension hooks for shot simulation and solution calculation WIP: Artillery Tables - Add additional extension hooks for shot simulation and solution calculation Jul 31, 2023
@LorenLuke LorenLuke changed the title WIP: Artillery Tables - Add additional extension hooks for shot simulation and solution calculation Artillery Tables - Add additional extension hooks for shot simulation and solution calculation Aug 4, 2023
@LinkIsGrim LinkIsGrim self-requested a review August 10, 2023 23:59
addons/artillerytables/functions/fnc_adjustFire.sqf Outdated Show resolved Hide resolved
addons/artillerytables/functions/fnc_adjustFire.sqf Outdated Show resolved Hide resolved
addons/artillerytables/functions/fnc_adjustFire.sqf Outdated Show resolved Hide resolved
params ["_ownPos", "_targetPos", "_adjustEast", "_adjustNorth", "_adjustUp", "_muzzleVelocity", "_airFriction", ["_highAngle", true], ["_temperature", 15], ["_airDensity", 1.225], ["_windDir", 0], ["_windSpeed", 0]];

//DEFAULT_AIR_FRICTION == -0.00006
//MK6_82mm_AIR_FRICTION == -0.0001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is intended to be a user-facing function then _airFriction should be handled by the function as well, IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with that is that it has to identify it as a mortar versus as an artillery shell, and I feel like that might fall into the weird 'special numbers' case, as it were, if any other mod were to use anything different.

(If you recall the demonstration with the shells falling short of predicted solutions, that was because it automatically added DEFAULT_AIR_FRICTION when I was using the mortar; I'd like to avoid that if possible just by making it enterable, and having some other function determine which value to use, as they were just included here for reference in testing).

addons/artillerytables/functions/fnc_adjustFire.sqf Outdated Show resolved Hide resolved
addons/artillerytables/functions/fnc_adjustFire.sqf Outdated Show resolved Hide resolved
@PabstMirror PabstMirror self-requested a review September 7, 2023 04:44
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.16.0 Sep 26, 2023
@PabstMirror
Copy link
Contributor

still planning on 3.16 just didn't want it in RC because extension problems with battleeye

@jonpas jonpas mentioned this pull request Sep 26, 2023
5 tasks
@jonpas jonpas modified the milestones: 3.16.0, 3.16.1 Oct 17, 2023
@jonpas
Copy link
Member

jonpas commented Oct 17, 2023

Do in #9015 and merge the Rust extensions after 3.16.0 release.

@PabstMirror PabstMirror modified the milestones: 3.16.1, Ongoing Oct 18, 2023
@LorenLuke
Copy link
Contributor Author

It's now 3.16.2... is this not happening?

@LinkIsGrim
Copy link
Contributor

It'll happen with #9015

BrettMayson added a commit to BrettMayson/ACE3 that referenced this pull request Jan 18, 2024
@johnb432
Copy link
Contributor

#9015 has been merged, therefore closing. Thanks @LorenLuke!

@johnb432 johnb432 closed this Aug 30, 2024
@johnb432 johnb432 removed this from the Ongoing milestone Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants