-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artillery Tables - Add additional extension hooks for shot simulation and solution calculation #9298
Conversation
Fixes bug with getting max distance in extension. Adds script functions for easier hooking.
ba7812b
to
1168694
Compare
params ["_ownPos", "_targetPos", "_adjustEast", "_adjustNorth", "_adjustUp", "_muzzleVelocity", "_airFriction", ["_highAngle", true], ["_temperature", 15], ["_airDensity", 1.225], ["_windDir", 0], ["_windSpeed", 0]]; | ||
|
||
//DEFAULT_AIR_FRICTION == -0.00006 | ||
//MK6_82mm_AIR_FRICTION == -0.0001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is intended to be a user-facing function then _airFriction
should be handled by the function as well, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with that is that it has to identify it as a mortar versus as an artillery shell, and I feel like that might fall into the weird 'special numbers' case, as it were, if any other mod were to use anything different.
(If you recall the demonstration with the shells falling short of predicted solutions, that was because it automatically added DEFAULT_AIR_FRICTION when I was using the mortar; I'd like to avoid that if possible just by making it enterable, and having some other function determine which value to use, as they were just included here for reference in testing).
still planning on 3.16 just didn't want it in RC because extension problems with battleeye |
Do in #9015 and merge the Rust extensions after 3.16.0 release. |
It's now 3.16.2... is this not happening? |
It'll happen with #9015 |
3eb9e3d
to
048efff
Compare
#9015 has been merged, therefore closing. Thanks @LorenLuke! |
When merged this pull request will:
To be used for a dedicated artillery computer.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.