-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow - fix hemtt lint, drop sqflint, fix ext clippy warnings #10219
Conversation
failing when building on linux
|
ugly but should work?
|
I can't remember why I added that feature, potentially it's not needed? |
hemtt check fails, but should work after merge |
@@ -56,7 +57,7 @@ impl Map { | |||
self.surface_is_water[index] = is_water; | |||
} | |||
|
|||
#[must_use] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the #[must_use]?
.github/workflows/arma.yml
Outdated
# lint: | ||
# runs-on: ubuntu-latest | ||
# steps: | ||
# - name: Checkout the source code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't like commenting out things, if we don't need it let's remove it, we'll likely not need this again and if we do we can find this PR
(Will only apply after merge)
Fix hemtt lint I think
ref https://github.com/acemod/ACE3/actions/runs/10434328035/job/28897068966?pr=10144
switch to
xcopy /y
use this to overwrite filesDisable sqflint, hasn't been updated in years (it doesn't understand
#
),I don't think anyone looks at it's output?
it does have the ability to catch some things like undefined/shadowed vars
but it has too many false positives to be useful imho
Fix extension lint
ref https://github.com/acemod/ACE3/actions/runs/10434327964/job/28897069005
possibly related to libgit2/libgit2#6279
but I don't really understand as checkout is doing
in any case it shouldn't hurt to make it buildable without git?