Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow - fix hemtt lint, drop sqflint, fix ext clippy warnings #10219

Merged
merged 10 commits into from
Aug 18, 2024

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Aug 17, 2024

(Will only apply after merge)

  thread 'main' panicked at extension/build.rs:2:46:
  Open git repo: Error { code: -36, klass: 7, message: "repository path '/__w/ACE3/ACE3' is not owned by current user" }

possibly related to libgit2/libgit2#6279
but I don't really understand as checkout is doing

Adding repository directory to the temporary git global config as a safe directory
/usr/bin/git config --global --add safe.directory /__w/ACE3/ACE3

in any case it shouldn't hurt to make it buildable without git?

@PabstMirror PabstMirror added the ignore-changelog Release Notes: Excluded label Aug 17, 2024
@PabstMirror PabstMirror added this to the Ongoing milestone Aug 17, 2024
@PabstMirror
Copy link
Contributor Author

failing when building on linux
if cfg!(feature = "clipboard") doesn't seem to be working?

error[E0433]: failed to resolve: use of undeclared crate or module `clipboard`
  --> extension/src/lib.rs:26:17
   |
26 |                 clipboard::group()
   |                 ^^^^^^^^^ use of undeclared crate or module `clipboard`

@PabstMirror
Copy link
Contributor Author

ugly but should work?

#[cfg(feature = "clipboard")]
#[arma]
fn init() -> Extension {
    Extension::build()
        .version(env!("GIT_HASH").to_string())
        .group("artillery", artillery::group())
        .group("ballistics", ballistics::group())
        .group("clipboard", clipboard::group())
        .command("break_line", break_line::break_line)
        .command("fcs", fcs::get_solution)
        .command("version", || env!("GIT_HASH"))
        .finish()
}

#[cfg(not(feature = "clipboard"))]
#[arma]
fn init() -> Extension {
    Extension::build()
        .version(env!("GIT_HASH").to_string())
        .group("artillery", artillery::group())
        .group("ballistics", ballistics::group())
        .command("break_line", break_line::break_line)
        .command("fcs", fcs::get_solution)
        .command("version", || env!("GIT_HASH"))
        .finish()
}

@BrettMayson
Copy link
Member

I can't remember why I added that feature, potentially it's not needed?

@PabstMirror PabstMirror changed the title workflow - try to fix hemtt.yml workflow - fix hemtt lint, drop sqflint, fix ext clippy warnings Aug 18, 2024
@PabstMirror
Copy link
Contributor Author

hemtt check fails, but should work after merge

@@ -56,7 +57,7 @@ impl Map {
self.surface_is_water[index] = is_water;
}

#[must_use]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the #[must_use]?

# lint:
# runs-on: ubuntu-latest
# steps:
# - name: Checkout the source code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't like commenting out things, if we don't need it let's remove it, we'll likely not need this again and if we do we can find this PR

@PabstMirror PabstMirror merged commit 1b210d8 into master Aug 18, 2024
7 of 8 checks passed
@PabstMirror PabstMirror deleted the maybeFixHemttWorkflow branch August 18, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants