Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(spire-agent): upgrade dependency packages #18

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

vishnusomank
Copy link

@vishnusomank vishnusomank commented Dec 12, 2023

This PR contains the following changes:
Updated

  • net package to v0.17.0 from v0.7.0
  • gRPC package to v1.56.3 from v1.53.0
  • docker package to v24.0.7 from v23.0.1+incompatible
  • distribution package to v2.8.2-beta.1 from v2.8.1+incompatible
  • go-jose to v3.0.1 from v3.0.0

@vishnusomank vishnusomank requested review from rajaSahil, a user and seswarrajan December 12, 2023 13:19
@vishnusomank vishnusomank force-pushed the dep-update branch 2 times, most recently from b359a39 to 1c35f0a Compare December 14, 2023 11:47
@vishnusomank vishnusomank changed the title update(spire-agent): update http net package update(spire-agent): upgrade dependency packages Dec 14, 2023
Copy link

@soorya-knox soorya-knox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnusomank Can you please take a look at the failing actions?

@vishnusomank
Copy link
Author

@vishnusomank Can you please take a look at the failing actions?

hi @soorya-knox , the GH action is failing due to token issue which can be solved by devops. Also we are not using this action to build spire. We have a separate repository for spire builds so this action is not required IMO

cc: @seswarrajan

@rajaSahil
Copy link

@vishnusomank Can you please fix checks?

@vishnusomank
Copy link
Author

@vishnusomank Can you please fix checks?

The checks are failing because of github token expired @rajaSahil also we are not building spire in this repo. we have a separate repo in accuknox to build spire before releasing

@rajaSahil
Copy link

@vishnusomank Can you please fix checks?

The checks are failing because of github token expired @rajaSahil also we are not building spire in this repo. we have a separate repo in accuknox to build spire before releasing

Then we can remove it from here, it's giving false impression IMO.

@vishnusomank
Copy link
Author

@vishnusomank Can you please fix checks?

The checks are failing because of github token expired @rajaSahil also we are not building spire in this repo. we have a separate repo in accuknox to build spire before releasing

Then we can remove it from here, it's giving false impression IMO.

yes. i'll raise a PR to remove the GH action from this repo

@rajaSahil rajaSahil merged commit f856eb8 into accuknox:ak-agent-isolation Feb 5, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants