Updated summary with pod's parent information #733

vishnusomank · 2023-05-24T13:19:18Z

Fixes: #731

Related PRs --> kubearmor/kubearmor-client#299

This PR contains the following changes:

Updated summary information to include pod's parent_name and parent_type
Updated functions to retrieve daemonset details
Updated constants with deployment, replicaset, statefulset and daemonset values
Updated protobuf definitions to include parent_name and parent_type to pod information

Please refer 299#issuecomment-1561132322 for the updated output

rajaSahil · 2023-06-05T11:38:23Z

src/protobuf/v1/observability/observability.proto

@@ -36,6 +37,7 @@ message Response{
    repeated CiliumSummData IngressData = 11;
    repeated CiliumSummData EgressData = 12;
    repeated SysNwSummaryData BindConnection = 13;
+    string DeployType = 14;


What does DeployType signify over here?

Shouldn't this be ResourceType?

k8s uses the term resource owner for this.

rajaSahil · 2023-06-05T11:57:47Z

src/protobuf/v1/observability/observability.proto

@@ -36,6 +37,7 @@ message Response{
    repeated CiliumSummData IngressData = 11;
    repeated CiliumSummData EgressData = 12;
    repeated SysNwSummaryData BindConnection = 13;
+    string DeployType = 14;


Shouldn't this be ResourceType?

rajaSahil · 2023-06-05T11:58:07Z

src/protobuf/v1/observability/observability.proto

@@ -20,6 +20,7 @@ message Request{
    string Type = 6;
    bool Aggregate = 7;
    string DeployName = 8;


Can we name this as ResourceName?

rajaSahil · 2023-06-05T11:58:46Z

src/types/constants.go

+	K8sDeploymentType = "Deployment"
+	K8sStatefulSetsType = "StatefulSet"
+	K8sReplicaSetsType = "ReplicaSet"
+	K8sDaemonSetsType = "DaemonSet"


Do we also need to add for jobs?

vishnusomank · 2023-06-07T08:02:57Z

@rajaSahil I've updated the code based on your comment. Can you please review again?
cc: @nyrahul

Ankurk99 · 2023-06-08T07:10:12Z

src/cluster/k8sClientHandler.go

+// == DaemonSets == //
+// ================= //
+
+func GetDaemonSetsFromK8sClient() []types.Deployment {


Can we create a single function and then pass the k8s objects as argument? like GetObjectSetsFromK8sClient(object), then pass daemonset/deployment etc. as a value to it. It will greatly reduce the code size

Addressed @Ankurk99

rajaSahil · 2023-06-12T03:42:48Z

src/cluster/k8sClientHandler.go

+			for _, rs := range replicaSets.Items {
+				results = append(results, GenerateResourceList(rs.OwnerReferences,rs.Name,rs.Namespace,types.K8sReplicaSetsType,rs.Spec.Selector.MatchLabels)...)
+			}
+		case types.K8sJobsType:


Do we also need to consider cronjobs? Although it creates new jobs periodically.

rajaSahil · 2023-06-12T03:44:29Z

src/conf/local-file.yaml

@@ -119,6 +119,7 @@ recommend:
  operation-mode: 1                       # 1: cronjob | 2: one-time-job
  cron-job-time-interval: "1h0m00s"       # format: XhYmZs
  recommend-host-policy: true
+  admission-controller-policy: false


Why this change?

rajaSahil · 2023-06-12T03:45:06Z

src/libs/dbHandler.go

@@ -433,7 +433,7 @@ func upsertSysSummarySQL(db *sql.DB, summary types.SystemSummary, timeCount type
 	summary.Labels = strings.Join(sortedLabels, ",")

 	queryString := `cluster_name = ? and cluster_id = ? and workspace_id = ? and namespace_name = ? and namespace_id = ? and container_name = ? and container_image = ? 
-					and podname = ? and operation = ? and labels = ? and deployment_name = ? and source = ? and destination = ? 
+					and podname = ? and operation = ? and labels = ? and parent_name = ? and parent_type = ? and source = ? and destination = ? 


Can we name table columns as resource_type and resource_name?

rajaSahil · 2023-06-12T03:46:34Z

src/libs/sqliteHandler.go

+			"	`parent_name` varchar(50) DEFAULT NULL," +
+			"	`parent_type` varchar(50) DEFAULT NULL," +


resource_type and resource_name ?

rajaSahil · 2023-06-12T03:48:21Z

src/libs/sqliteHandler.go

 	db := connectSQLite(cfg, config.GetCfgObservabilityDBName())
 	defer db.Close()

-	resDeployNames := []string{}
+	resDeployNames := map[string]string{}

 	var results *sql.Rows
 	var err error

 	// Get podnames from system table


Suggested change

// Get podnames from system table

// Get resource type and resource names from system table.

rajaSahil · 2023-06-12T03:49:59Z

src/libs/sqliteHandler.go

+		var locDeployName, locDeployType string
 		if err := results.Scan(
 			&locDeployName,
+			&locDeployType,
 		); err != nil {
 			return nil, err
 		}
-		resDeployNames = append(resDeployNames, locDeployName)
+		resDeployNames[locDeployName] = locDeployType


There can be possibility of having same resource names in different namespace, so when getting all the entries from table, are we handling this case?

rajaSahil · 2023-06-12T03:51:31Z

src/observability/summarizer.go

+			}
+		}
+		if sysSummary.Deployment == "" {
+			sysSummary.Workload.Type = "Pod"


Is it correct to consider pod as a workload type?

- Updated summary information to include pod's parent_name and parent_type - Updated functions to retrieve daemonset details - Updated constants with deployment, replicaset, statefulset, daemonset and jobs values - Updated protobuf definitions to include parent_name and parent_type to pod information Signed-off-by: Vishnu Soman <[email protected]>

seswarrajan · 2023-10-08T15:00:48Z

Currently putting this on hold as we are handling summary through different CLI tool

vishnusomank requested review from nyrahul, Ankurk99 and seswarrajan May 24, 2023 13:19

vishnusomank changed the title ~~Updated summary information to add pods parent information~~ Updated summary with pod's parent information May 24, 2023

rajaSahil reviewed Jun 5, 2023

View reviewed changes

vishnusomank force-pushed the summary-deploy branch 3 times, most recently from 87eb5ba to 67effbc Compare June 7, 2023 08:00

vishnusomank requested a review from rajaSahil June 7, 2023 08:02

Ankurk99 reviewed Jun 8, 2023

View reviewed changes

vishnusomank force-pushed the summary-deploy branch from 67effbc to 83c0441 Compare June 9, 2023 04:48

vishnusomank requested a review from Ankurk99 June 9, 2023 05:57

rajaSahil reviewed Jun 12, 2023

View reviewed changes

vishnusomank force-pushed the summary-deploy branch from 83c0441 to e586e08 Compare June 12, 2023 11:09

seswarrajan closed this Oct 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated summary with pod's parent information #733

Updated summary with pod's parent information #733

vishnusomank commented May 24, 2023

rajaSahil Jun 5, 2023

rajaSahil Jun 5, 2023

nyrahul Jun 6, 2023

rajaSahil Jun 5, 2023

rajaSahil Jun 5, 2023

rajaSahil Jun 5, 2023

vishnusomank commented Jun 7, 2023

Ankurk99 Jun 8, 2023

vishnusomank Jun 9, 2023

rajaSahil Jun 12, 2023

rajaSahil Jun 12, 2023

rajaSahil Jun 12, 2023

rajaSahil Jun 12, 2023

rajaSahil Jun 12, 2023

rajaSahil Jun 12, 2023

rajaSahil Jun 12, 2023

seswarrajan commented Oct 8, 2023

		" `parent_name` varchar(50) DEFAULT NULL," +
		" `parent_type` varchar(50) DEFAULT NULL," +

	// Get podnames from system table
	// Get resource type and resource names from system table.

Updated summary with pod's parent information #733

Updated summary with pod's parent information #733

Conversation

vishnusomank commented May 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vishnusomank commented Jun 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seswarrajan commented Oct 8, 2023