Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add complete arguments to GetHardenPolicy(..) in recommend test #716

Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix: Add complete arguments to GetHardenPolicy(..) in recommend test #716

merged 1 commit into from
Apr 26, 2023

Conversation

Vyom-Yadav
Copy link
Contributor

Signed-off-by: Vyom-Yadav [email protected]

Changes:

  • The test suite was not compilable as GetHardenPolicy(..) wasn't called with enough arguments, added the missing argument.
  • go mod tidy

@nyrahul nyrahul requested review from Shreyas220 and removed request for Prateeknandle April 26, 2023 17:23
@Vyom-Yadav
Copy link
Contributor Author

The current CI failure is a known flake #682

nyrahul
nyrahul approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for handling this.

@nyrahul nyrahul merged commit 8538965 into accuknox:dev Apr 26, 2023
@Vyom-Yadav Vyom-Yadav deleted the fixCIFailure branch April 26, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyrahul nyrahul nyrahul approved these changes

@Shreyas220 Shreyas220 Awaiting requested review from Shreyas220

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vyom-Yadav @nyrahul