Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update system policies correctly #680

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

Vyom-Yadav
Copy link
Contributor

Signed-off-by: Vyom-Yadav [email protected]

Rationale:

Network policies were updated instead of system policies. Network policies are already being updated at:

func UpdateOutdatedNetworkPolicy(cfg types.ConfigDB, outdatedPolicy string, latestPolicy string) {
if cfg.DBDriver == "mysql" {
if err := UpdateOutdatedNetworkPolicyFromMySQL(cfg, outdatedPolicy, latestPolicy); err != nil {
log.Error().Msg(err.Error())
}
} else if cfg.DBDriver == "sqlite3" {
if err := UpdateOutdatedNetworkPolicyFromSQLite(cfg, outdatedPolicy, latestPolicy); err != nil {
log.Error().Msg(err.Error())
}
}
}

@Vyom-Yadav Vyom-Yadav force-pushed the updateCorrectPolicy branch from eb2eb0c to a4853a2 Compare March 9, 2023 07:03
@Vyom-Yadav
Copy link
Contributor Author

CI failure is due to #682

@Vyom-Yadav Vyom-Yadav force-pushed the updateCorrectPolicy branch 2 times, most recently from deed5a1 to d7dfd87 Compare April 1, 2023 14:16
@Vyom-Yadav
Copy link
Contributor Author

@seswarrajan Ping

@Vyom-Yadav Vyom-Yadav requested a review from seswarrajan April 7, 2023 17:36
@Vyom-Yadav Vyom-Yadav force-pushed the updateCorrectPolicy branch from 00ee4d9 to 6a70fd8 Compare April 13, 2023 05:59
@Vyom-Yadav
Copy link
Contributor Author

CI failure is due to #682

@Vyom-Yadav Vyom-Yadav merged commit 9aaee57 into accuknox:dev Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants