Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should trigger the new codeql action #1263

Closed
wants to merge 1 commit into from
Closed

should trigger the new codeql action #1263

wants to merge 1 commit into from

Conversation

darkbasic
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Nov 19, 2023

⚠️ No Changeset found

Latest commit: 28805a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 19, 2023

💻 Website Preview

The latest changes are available as preview in: https://fc2bb56f.accounts-js.pages.dev

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (17410d6) 92.71% compared to head (28805a0) 92.23%.

Files Patch % Lines
packages/password/src/endpoints/express.ts 18.75% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage   92.71%   92.23%   -0.48%     
==========================================
  Files         116      116              
  Lines        2483     2499      +16     
  Branches      562      567       +5     
==========================================
+ Hits         2302     2305       +3     
- Misses        167      179      +12     
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +90 to +95
getHtml(
'Email verification error',
`
<h3>The email address couldn't be verified: ${err.message ?? 'unknown error'}</h3>
`
)

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML Medium

Exception text
is reinterpreted as HTML without escaping meta-characters.
Comment on lines +158 to +172
getHtml(
'Reset password',
`
<div class="container">
<h1>Reset your password</h1>
<form action="/resetPassword" method="POST">
<input type="hidden" name="token" value=${req.params.token} />
<div class="form-group">
<label for="newPassword">New password</label>
<input type="text" class="form-control" id="newPassword" value="" placeholder="Enter your new password" name="newPassword">
</div>
<button type="submit" class="btn btn-primary">Submit</button>
</form>
`
)

Check warning

Code scanning / CodeQL

Reflected cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
.
@darkbasic darkbasic closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant