Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(markdown-docx): remove argument ooxml in toOOXML - #397 #412

Merged

Conversation

K-Kumar-01
Copy link
Collaborator

Signed-off-by: k-kumar-01 [email protected]

Removes the ooxml argument in toOOXML function and update the docstrings accordingly.

Changes

  • Removes ooxml argument.
  • Docstring update.

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

@K-Kumar-01 K-Kumar-01 requested a review from algomaster99 June 17, 2021 19:34
@algomaster99 algomaster99 changed the title refactor(markdown-docx): remove argument ooxml in toOOXML func - #397 refactor(markdown-docx): remove argument ooxml in toOOXML - #397 Jun 17, 2021
@algomaster99 algomaster99 merged commit 3697881 into algoo-ooxml Jun 17, 2021
@algomaster99 algomaster99 deleted the k-kumar-01/i397/use-ooxml-instance-variable branch June 17, 2021 19:37
algomaster99 pushed a commit that referenced this pull request Jun 17, 2021
@algomaster99
Copy link
Member

algomaster99 commented Jun 17, 2021

@K-Kumar-01 Execute git pull algo-ooxml --rebase on the algo-ooxml branch before committing anything on a new branch. master had changes so I rebased the algo-ooxml branch.

@algomaster99
Copy link
Member

Just hold on a minute. I screwed something on the algo-ooxml branch. Fixing that.

algomaster99 pushed a commit that referenced this pull request Jun 17, 2021
@algomaster99
Copy link
Member

@K-Kumar-01 I resolved it. Next, execute git pull algo-ooxml --rebase on algo-ooxml branch before checking out any branch from algo-ooxml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants