Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Ruby 3 compatibility #21

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Ensure Ruby 3 compatibility #21

wants to merge 3 commits into from

Conversation

w-le
Copy link
Contributor

@w-le w-le commented Aug 19, 2024

Error 1:

[error] unhandled exception: wrong number of arguments (given 1, expected 0; required keywords: status, callback, on_thread) (performing next tick callback)
/home/aca-apps/ruby-engine/lib/orchestrator/status.rb:52:in `subscribe'
/home/aca-apps/ruby-engine/lib/orchestrator/websocket_manager.rb:304:in `block in try_bind'

at https://github.com/acaprojects/ruby-engine/blob/master/lib/orchestrator/status.rb#L52
called by https://github.com/acaprojects/ruby-engine/blob/master/lib/orchestrator/websocket_manager.rb#L304

@w-le w-le self-assigned this Aug 19, 2024
@w-le
Copy link
Contributor Author

w-le commented Aug 19, 2024

If the changes in this PR are not 100% Ruby2 compatible then this PR will be deleted (without merge) and the Ruby3 apps will just be built with ruby-engine on branch fix/ruby3 instead of master

@w-le
Copy link
Contributor Author

w-le commented Aug 19, 2024

With the changes the deployed, the error has now changed to:

[error] unhandled exception: wrong number of arguments (given 9, expected 0; required keywords: status, callback, on_thread) (performing next tick callback)
/home/aca-apps/ruby-engine/lib/orchestrator/status.rb:53:in `subscribe'
/home/aca-apps/ruby-engine/lib/orchestrator/websocket_manager.rb:304:in `block in try_bind'

So the syntax is still not correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant