WIP: Sony lcd #70
WIP: Sony lcd #70
Conversation
| send("8C 00 00 02 01 8F", hex_string: true) | ||
| logger.debug "-- sony display requested to power on" | ||
| else | ||
| send("8C 00 00 02 01 8F", hex_string: true) |
There was a problem hiding this comment.
This is the same hex string as the power on command. Is this a toggle?
There was a problem hiding this comment.
We believe so, not 100% sure, hence added the else statement just to be sure.
There was a problem hiding this comment.
The protocol doc in the comment at the top of this file makes reference to both power on and power off commands?
Regardless, if only a toggle is supported, provide a power method that accepts a state param, but always toggles is a little disingenuous. With this user would expect to be able to call power :on or power :off and have the device state reflect this. If there are no discrete power commands it's worth using the current known state (if this is accurate) to only execute the toggle is required.
removed schedule.clear and power state options.
| send("8C 00 00 02 01 8F", hex_string: true) | ||
| logger.debug "-- sony display requested to power on" | ||
| else | ||
| send("8C 00 00 02 01 8F", hex_string: true) |
There was a problem hiding this comment.
The protocol doc in the comment at the top of this file makes reference to both power on and power off commands?
Regardless, if only a toggle is supported, provide a power method that accepts a state param, but always toggles is a little disingenuous. With this user would expect to be able to call power :on or power :off and have the device state reflect this. If there are no discrete power commands it's worth using the current known state (if this is accurate) to only execute the toggle is required.
|
@jwest-aca can you jump back on this and close off some of these items / merge when ready? |
Description
Sony CBX (RS-232 Control over HDMI) Module written for PWC. Tested and working on branch, can now be merged into master.
Fixes # (issue)
Type of change
Has this been tested?
Check all that apply.