Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodejs usage on README - field name, writeFile callback #676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devgony
Copy link

@devgony devgony commented Jan 4, 2024

Goal

Currently nodejs usage on README.md does not work.
It should be executable only by copying and pasting for beginners.

Todo

  • fix: correct files' field to use latest name
  • fix: writeFile takes callback

@devgony devgony changed the base branch from master to next January 4, 2024 14:11
@smorimoto smorimoto changed the base branch from next to master May 8, 2024 01:09
@smorimoto smorimoto requested a review from Copilot December 28, 2024 17:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

README.md:191

  • [nitpick] The variable name fileExtension is inconsistent with the other field names. It should be renamed to fileExt to maintain consistency.
files.forEach(({ fileContent, fileName, fileExtension }) => {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant