Skip to content

Commit

Permalink
Removed coveralls step and changed readme badges
Browse files Browse the repository at this point in the history
  • Loading branch information
FrederikP committed Jan 5, 2021
1 parent 32c041e commit 6ebe08a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ jobs:
uses: actions/download-artifact@v2
with:
name: coverage
- name: Debug downloaded artifacts
id: debug_downloaded_artifacts
run: |
ls -ahl
- name: Coveralls
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
# - name: Debug downloaded artifacts
# id: debug_downloaded_artifacts
# run: |
# ls -ahl
# - name: Coveralls
# uses: coverallsapp/github-action@master
# with:
# github-token: ${{ secrets.GITHUB_TOKEN }}
- uses: codecov/codecov-action@v1
with:
fail_ci_if_error: true # optional (default = false)
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ Find the latest schema release [on the releases page](https://github.com/abusix/

## Build status

[![Build Status](https://travis-ci.org/abusix/xarf.svg?branch=master)](https://travis-ci.org/abusix/xarf)
[![Build Status](https://img.shields.io/github/workflow/status/abusix/xarf/xarf-ci/master)](https://github.com/abusix/xarf/actions?query=workflow%3Axarf-ci)

## Coverage

[![Coverage Status](https://coveralls.io/repos/github/abusix/xarf/badge.svg)](https://coveralls.io/github/abusix/xarf)
[![Coverage Status](https://img.shields.io/codecov/c/github/abusix/xarf)](https://codecov.io/gh/abusix/xarf/branch/master)

Please note that you won't be able to see source code for the generated code due to the way coveralls works. CodeCov is even worse, it doesn't even show percentages for code that doesn't exist in the repo.
The coverage will probably never reach 100% because of the way the code is generated, but it is still a useful metric to see how well our samples cover the schema.
Expand Down

0 comments on commit 6ebe08a

Please sign in to comment.