Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abtris/fix GitHub 56 #67

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Abtris/fix GitHub 56 #67

merged 2 commits into from
Oct 12, 2023

Conversation

abtris
Copy link
Owner

@abtris abtris commented Oct 12, 2023

Close #66

@@ -7,7 +7,7 @@ import (
"strings"
"time"

"github.com/google/go-github/v55/github"
"github.com/google/go-github/v56/github"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
import 'github.com/google/go-github/v56/github' is not allowed from list 'Main' (depguard)

@@ -6,7 +6,7 @@ import (
"log"
"os"

"github.com/google/go-github/v55/github"
"github.com/google/go-github/v56/github"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
import 'github.com/google/go-github/v56/github' is not allowed from list 'Main' (depguard)

@@ -4,7 +4,7 @@ import (
"context"
"testing"

"github.com/google/go-github/v55/github"
"github.com/google/go-github/v56/github"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
import 'github.com/google/go-github/v56/github' is not allowed from list 'Main' (depguard)

@@ -136,7 +136,8 @@ func pushCommit(ctx context.Context, client *github.Client, owner, repo string,
Tree: tree,
Parents: []*github.Commit{parent.Commit},
}
newCommit, _, err := client.Git.CreateCommit(ctx, owner, repo, commit)
opts := &github.CreateCommitOptions{}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Signer is missing in CreateCommitOptions (exhaustivestruct)

@abtris abtris merged commit 00dfe46 into master Oct 12, 2023
10 checks passed
@abtris abtris deleted the abtris/fix-github-56 branch October 12, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant