NOISSUE - Switch to Consumers interface #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
force-pushed
the
consumers
branch
2 times, most recently
from
792e57a to
c2c5853
Compare
Codecov Report
@@ Coverage Diff @@
## master absmach/supermq#1316 +/- ##
=======================================
Coverage 59.79% 59.79%
=======================================
Files 113 113
Lines 8797 8797
=======================================
Hits 5260 5260
Misses 3080 3080
Partials 457 457
Continue to review full report at Codecov.
|
drasko
requested changes
Jan 5, 2021
consumers/writers/README.md
Outdated
| @@ -0,0 +1,16 @@ | |||
| # Writers | |||
|
|
|||
| Writers provide an implementation of various `message writers`. | |||
There was a problem hiding this comment.
Is this now rather implementation of Consumer interface?
There was a problem hiding this comment.
I would add a README for consumers and keep this one
Signed-off-by: dusanb94 <[email protected]>
Signed-off-by: dusanb94 <[email protected]>
Signed-off-by: dusanb94 <[email protected]>
dborovcanin
force-pushed
the
consumers
branch
from
1cbbc65 to
c2ab3ae
Compare
Signed-off-by: dusanb94 <[email protected]>
Signed-off-by: dusanb94 <[email protected]>
Signed-off-by: dusanb94 <[email protected]>
Signed-off-by: dusanb94 <[email protected]>
Signed-off-by: dusanb94 <[email protected]>
dborovcanin
force-pushed
the
consumers
branch
from
c2ab3ae to
adc70d8
Compare
Signed-off-by: dusanb94 <[email protected]>
fbugarski
pushed a commit
to fbugarski/mainflux
that referenced
this pull request
Mar 8, 2021
* Replace Writer with Consumer Signed-off-by: dusanb94 <[email protected]> * Add Notifications package Signed-off-by: dusanb94 <[email protected]> * Update Consumer Start Signed-off-by: dusanb94 <[email protected]> * Fix Readers Signed-off-by: dusanb94 <[email protected]> * Fix Consumer naming Signed-off-by: dusanb94 <[email protected]> * Add repo to Notify Signed-off-by: dusanb94 <[email protected]> * Remove notify Signed-off-by: dusanb94 <[email protected]> * Rename consumer field in middlewares Signed-off-by: dusanb94 <[email protected]> * Fix remarks and add Readme Signed-off-by: dusanb94 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Replace Writer interface with Consumer.
Which issue(s) does this PR fix/relate to?
There is no such issue.
List any changes that modify/break current functionality
There are no such changes. This pull request will be followed by pull requests that resolve #1311 and absmach/magistrala#13, which will be just another Mainflux Consumer alongside Mainflux Writers.
Have you included tests for your changes?
No.
Did you document any new/modified functionality?
No.