PROP-26 - Implement Proplet #6
JeffMboyaAnnotations
10 errors and 1 warning
|
Lint and Build:
cmd/proplet/main.go#L51
exitAfterDefer: os.Exit will exit, and `defer cancel()` will not run (gocritic)
|
|
Lint and Build:
cmd/proplet/main.go#L118
httpNoBody: http.NoBody should be preferred to the nil request body (gocritic)
|
|
Lint and Build:
proplet/service.go#L135
Function `Run$1->handleStartCommand->handleStartCommand$1->deployAndRunApp` should pass the context parameter (contextcheck)
|
|
Lint and Build:
proplet/service.go#L138
Function `Run$2->handleStopCommand` should pass the context parameter (contextcheck)
|
|
Lint and Build:
proplet/service.go#L141
Function `Run$3->registryUpdate` should pass the context parameter (contextcheck)
|
|
Lint and Build:
proplet/service.go#L152
Function `Run$4->handleChunk->deployAndRunApp` should pass the context parameter (contextcheck)
|
|
Lint and Build:
proplet/config.go#L39
calculated cyclomatic complexity for function Validate is 12, max is 10 (cyclop)
|
|
Lint and Build:
proplet/config.go#L41
fmt.Errorf can be replaced with errors.New (perfsprint)
|
|
Lint and Build:
proplet/config.go#L47
fmt.Errorf can be replaced with errors.New (perfsprint)
|
|
Lint and Build:
proplet/config.go#L50
fmt.Errorf can be replaced with errors.New (perfsprint)
|
|
Lint and Build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|