NOISSUE - Forward /health and /metrics endpoints
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates configuration and HTTP handling in the mproxy package by renaming PathPrefix field and a CleanPathPrefix function. Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Adds a feature to serve metrics and health endpoints directly without proxying. This ensures that metrics and health checks are handled efficiently. Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
`WARN [linters_context] gocritic: no need to enable check "captLocal": it's already enabled` This applies to the removed linters Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
dborovcanin
changed the title
/health and /metrics endpoints /health and /metrics endpoints
dborovcanin
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rodney Osodo [email protected]
What does this do?
PrefixPathtoPathPrefixCleanPathPrefixfunction to clean the path prefix used both by WebSocket and HTTP/metricsand/healthendpointsWhich issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
*_PATH_PREFIXenv variable has been renamed/metricsand/healthendpoints are served directly. This was an issue with testing http-adapter using schemathesis https://github.com/absmach/magistrala/pull/2212Have you included tests for your changes?
Manually tested the changes
Did you document any new/modified functionality?
Yes, Updated documentation
Notes
N/A