MG-209 - Update Linechart to facilitate multiple line charts #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage ? 81.00%
=======================================
Files ? 3
Lines ? 179
Branches ? 0
=======================================
Hits ? 145
Misses ? 18
Partials ? 16 ☔ View full report in Codecov by Sentry. |
ianmuchyri
force-pushed
the
209-multiplelinechart
branch
from
6e70c79 to
2097a8b
Compare
dborovcanin
requested changes
Mar 15, 2024
Musilah
reviewed
Mar 19, 2024
| <input type="color" class="form-control" name="lineColor" /> | ||
| </td> | ||
| <td class="text-center"> | ||
| <button type="button" class="btn btn-sm" onclick="removeRow(this)"> |
There was a problem hiding this comment.
removeRow has not been defined. Change to removeLineChartRow
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
the y-axis array data is updated after to ensure that all arrays have the same length Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
ianmuchyri
force-pushed
the
209-multiplelinechart
branch
from
264d570 to
56f42fc
Compare
felixgateru
requested changes
Mar 20, 2024
felixgateru
requested changes
Mar 20, 2024
The title and series names need to be adjusted. As well as the name gap on the y axis label and the position of the x axis label. |
felixgateru
requested changes
Mar 20, 2024
| }) | ||
| }); | ||
|
|
||
| function addLineChartRow() { |
There was a problem hiding this comment.
The rows are added but not removed on close or submit.
Signed-off-by: ianmuchyri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Updates the line chart to provision for multiple line charts
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes