NOISSUE - Readproperty #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
add bvlc update npdu add transport Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
The BACnetValue.Decode() method now returns an error to handle decoding errors properly. - The method signature has been updated to return (int, error) - If there is an error during decoding, the method now returns (-1, err) This change ensures that decoding errors are properly handled and allows for better error reporting and debugging. Signed-off-by: SammyOina <[email protected]>
…eadPropertyACK.Decode() method The decoding error for object_identifier and property_identifier in the ReadPropertyACK.Decode() method has been fixed. This change ensures that the error message accurately reflects the cause of the decoding failure. This commit addresses the following changes: - Updated error message for object_identifier decoding error - Updated error message for property_identifier decoding error Signed-off-by: SammyOina <[email protected]>
The BACnetValue.Decode() method was updated to handle decoding errors in the ReadAccessSpecification and BACnetDeviceObjectPropertyReference types. This ensures that the decoding process is accurate and reliable. Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
…oding The commit fixes the issue where unnecessary print statements were present in the code. Additionally, it adds the decoding of the BACnet message in the response of the read property example. Signed-off-by: SammyOina <[email protected]>
The commit fixes an incorrect comparison in the IAM.go file. The tagNumber variable is now correctly compared to the BACnetObjectIdentifier constant. Also adds write property. Signed-off-by: SammyOina <[email protected]>
This commit adds a new file writeProperty.go which contains an example main function for writing a BACnet property value. The function sets up the necessary variables and creates the NPDU (Network Protocol Data Unit) for sending the request to the BACnet device. It then encodes the NPDU and creates the APDU (Application Protocol Data Unit) with the necessary information for a WriteProperty service request. The purpose of this commit is to provide the functionality for writing a BACnet property value to a BACnet device. Signed-off-by: SammyOina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Support for read property requests.
Signed-off-by: SammyOina [email protected]