Update skeleton #39
Merged
Update skeleton #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Create copyright statement from holder information Signed-off-by: Jono Yang <[email protected]>
* This is used for the case where we are starting off a project and have not yet generated requirements files Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Replace all references to `tmp` with `venv` Signed-off-by: Jono Yang <[email protected]>
* Add --init option to configure.bat
* Update help text in configure and configure.bat
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Update README.rst Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
update-skeleton
branch
2 times, most recently
from
8f17516
to
51981b3
Compare
Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
update-skeleton
branch
from
51981b3
to
9c78ddb
Compare
* Update README.rst with instructions for post-initialization usage Signed-off-by: Jono Yang <[email protected]>
JonoYang
commented
Sep 4, 2021
| def get_license_keys(self): | ||
| try: | ||
| keys = LICENSING.license_keys(self.license_expression, unique=True, simple=True) | ||
| except license_expression.ExpressionParseError: |
There was a problem hiding this comment.
I ran into an issue with the license_expression library throwing an ExpressionParseError when I ran the bootstrap.py script without scancode-toolkit installed. The license expression for this package was the classifier strings that contain the license. The LICENSING object would balk at the symbol License. My initial reaction to this is to return a list that only contains unknown, but I am not sure if this would be the best thing to do.
|
The usage instructions should be moved to the docs directory rather than being placed in README.rst |
pombredanne
approved these changes
Sep 7, 2021
configure.bat
Outdated
| if "%1" EQU "--init" ( | ||
| set "NO_INDEX= " | ||
| ) | ||
| if "%1" EQU "--python" ( |
There was a problem hiding this comment.
At this stage this can be removed entirely IMHO
etc/scripts/fix_thirdparty.py
Outdated
| # ScanCode is a trademark of nexB Inc. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # See http://www.apache.org/licenses/LICENSE-2.0 for the license text. | ||
| # See https://github.com/nexB/scancode-toolkit for support or download. |
There was a problem hiding this comment.
you need to switch the URLs to skeleton
Signed-off-by: Philippe Ombredanne <[email protected]>
* Replace references to scancode-toolkit repo with links to the skeleton repo
* Remove --python option from configure.bat
Signed-off-by: Jono Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #31 #33 #34 #37 #38