-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 180: Fix not parsing pip.conf index urls #181
base: main
Are you sure you want to change the base?
Conversation
b1f7f47
to
088c157
Compare
I cannot get a good grasp on why the tests are failing. The diffs are a bit too long and the only change should be in the index_urls. If empty, then it should be equivalent to the same as before. If not, then yes things would change, but searching for the specific part in the diff is almost impossible. |
After running:
Then there are some pycodestyle failures in my recently added code, however, there are still other failures that have to do with package versions not being exact. I can change those etc. although it's certainly not what this PR is meant to do. |
Signed-off-by: Cesar Lizarraga <[email protected]>
Signed-off-by: Cesar Lizarraga <[email protected]>
Signed-off-by: Cesar Lizarraga <[email protected]>
Signed-off-by: Cesar Lizarraga <[email protected]>
Signed-off-by: Cesar Lizarraga <[email protected]>
Signed-off-by: Cesar Lizarraga <[email protected]>
e570ce8
to
575858d
Compare
Signed-off-by: Cesar Lizarraga <[email protected]>
Note that @heliocastro already filed #170, which seems to be related. |
They are incredibly related if not almost identical. However, pip warns against using it as a library
|
Fixes: #180
pip
prefers the usage of the CLI tool to get information, therefore I resorted tosubprocess
for this. This should get the information from thepip
CLI tool and then add it into theindex_urls
tuple.Thanks.