chat: Some clarifications around presence data #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They make it look like you’re meant to nest something inside a JSON object.
I’m treating this as a clarification rather than a new spec point, since it describes the behaviour of all of our current implementations of the Chat SDK.
Based on the behaviour of JS at 69ea478. Note that the <pre> is causing Textile to render CHA-PR2b in a separate <ul> to CHA-PR2a. I briefly tried various combinations of indentation, didn’t get anywhere, and gave up trying to fix it. Resolves #256.
lawrence-forooghian
requested review from
AndyTWF,
sacOO7,
maratal,
umair-ably and
ttypic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #256. See commit messages.