chat: add async rooms spec #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyTWF
force-pushed
the
chat-lifecycle
branch
from
8ebed8d to
3b576d3
Compare
|
Looks like there are some commits not related to the change above, it'll make this difficult to review. Is it possible to review, could we have a branch with the specific spec changes please? |
Yep - just need to rebase now the big one has landed. Will do that now! |
AndyTWF
force-pushed
the
chat-async-rooms
branch
from
5eca441 to
b32a74a
Compare
AndyTWF
force-pushed
the
chat-async-rooms
branch
from
b32a74a to
9fffff0
Compare
AndyTWF
force-pushed
the
chat-async-rooms
branch
from
9fffff0 to
1ca63a2
Compare
This change adds the specification for async room get in Chat.
AndyTWF
force-pushed
the
chat-async-rooms
branch
from
1ca63a2 to
f3aa677
Compare
splindsay-92
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the specification for async room get in Chat.
It also makes the room lifecycle changes in relation to CHADR-062.
CHA-669
CHA-637