Merge main into integration/3.0.0
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(RTN20): DISCONNECTING -> DISCONNECTED
Re-add RTN16d (accidentally removed)
spec: add RTS5 - create a derived channel
And trivial reword to some related spec items
Add exception to resent-messages-on-new-transport if queueMessages=false
Add `ChannelStateChange.hasBacklog` and return `ChannelStateChange` from attach/subscribe
The spec point exists but we had forgotten to add to IDL.
…o-IDL Add `Message#connectionKey` to IDL
…iggered by event other than `CalledActivate`, `updatedCallback:` with no error should be called. Updated RSH3e3a spec point, making `updateFailedCallback:` obsolete.
Added optional new `updatedCallback:` callback.
These were never implemented in any SDK so is safe to remove without deprectation
Co-authored-by: Lawrence Forooghian <[email protected]>
Co-authored-by: Lawrence Forooghian <[email protected]>
New batch specs
This was a mistake in 97186e7; the API response is a single BatchResult. The single-specifier variant is now redundant so I’ve removed that too.
Fix return type of `revokeTokens`
This was a mistake in 038b50e; the API response is a single BatchResult. RSC23 was already correct, just the IDL needs changing.
Fix return type of `batchPresence`
Added RSH3e2c spec point
Oops, I missed this in 595fdce.
Fix signature of `RealtimeClient#batchPresence`
I don't think these are appropriate or useful any more. Feels like the pairing of (feature spec + protocol documentation) should be self-contained. Mentioned the same thing in b77d7c9.
Remove references to Ruby documentation
feat: blue links
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a merge conflict.