add RSL6a3 msgpack fixture tests #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amnonbc please add a PR description with some context about why we're adding this. |
lmars
reviewed
Mar 20, 2023
Co-authored-by: Lewis Marshall <[email protected]>
owenpearson
requested changes
Mar 21, 2023
Co-authored-by: Owen Pearson <[email protected]>
mattheworiordan
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ably/ably-common#181 added a set of test fixtures to test the binary encoding protocol-messages.
ably/ably-go#588 adds test which check that these fixtures are decoded correctly, and that re-encoding them gets back to the original fixture.
This PR proposes that all SDKs write tests that use these fixtures, ensuring that all our SDKs can read and write the same binary format.