Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat spec does not reflect latest message field names #254

Open
lawrence-forooghian opened this issue Dec 4, 2024 · 2 comments
Open

Chat spec does not reflect latest message field names #254

lawrence-forooghian opened this issue Dec 4, 2024 · 2 comments
Assignees
@AndyTWF
Labels
chat Related to the Chat SDK.

Comments

@lawrence-forooghian
Copy link
Collaborator

We currently have an integration test failure in Swift (ably/ably-chat-swift#169) because chat messages are missing a latestAction key. It looks like the field names that were introduced into this spec in #216 no longer match those being used by Realtime. The JS Chat SDK was updated to use the new field names in ably/ably-chat-js#427 but this hasn't been reflected in the spec.

From what I can tell from that JS PR:

  • latestAction is now action
  • latestActionSerial is now version
  • latestActionDetails is now operation

Please can the spec be updated so that we can update Swift accordingly?
@lawrence-forooghian lawrence-forooghian added the chat Related to the Chat SDK. label Dec 4, 2024
@lawrence-forooghian
Copy link
Collaborator Author

cc @vladvelici @maratal

@lawrence-forooghian
Copy link
Collaborator Author

I’ll probably change the name of latestAction in Swift just to unblock us for now, but these changes should be formalised.

@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 4, 2024
Open
lawrence-forooghian added a commit to ably/ably-chat-swift that referenced this issue Dec 4, 2024
@lawrence-forooghian
Rename Message.latestAction to action
25e3f41 
Upon our integration tests starting to fail, we noticed that Realtime
seems to have renamed the `latestAction` property to `action`. This
change has not yet been reflected in the spec, but has been in JS [1].

I’ve created an issue to get the spec updated [2] but since this test
failure is stopping us from merging anything else I am going to rename
this property until we get a more definitive answer.

Part of #169.

[1] ably/ably-chat-js#427
[2] ably/specification#254
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyTWF AndyTWF

Labels
chat Related to the Chat SDK.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndyTWF @lawrence-forooghian