Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests are failing due to a missing latestAction key #169

Open
lawrence-forooghian opened this issue Dec 2, 2024 · 2 comments
Open

Integration tests are failing due to a missing latestAction key #169

lawrence-forooghian opened this issue Dec 2, 2024 · 2 comments
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Dec 2, 2024 •
edited by sync-by-unito bot
Loading

e.g. https://github.com/ably/ably-chat-swift/actions/runs/12127237918/job/33811110604?pr=168

Test basicIntegrationTest() recorded an issue at IntegrationTests.swift:55:6: Caught error: keyNotFound(CodingKeys(stringValue: "latestAction", intValue: nil), Swift.DecodingError.Context(codingPath: [_CodingKey(stringValue: "Index 0", intValue: 0)], debugDescription: "No value associated with key CodingKeys(stringValue: "latestAction", intValue: nil) ("latestAction").", underlyingError: nil))

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Dec 2, 2024
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 2, 2024
Closed
This was referenced Dec 2, 2024
Merged
Merged
@maratal
Copy link
Collaborator

maratal commented Dec 3, 2024

@AndyTWF @ttypic Was latestAction renamed to action recently? Looks like so:

Screenshot 2024-12-03 at 00 28 08

fyi @lawrence-forooghian

This was referenced Dec 3, 2024
Merged
Merged
lawrence-forooghian added a commit that referenced this issue Dec 4, 2024
@lawrence-forooghian
Introduce a wait to work around history not being “live”
1cb8801 
(The integration tests are still failing, though, due to #169, but at
least they’re now failing in a consistent manner.)

Resolves #167.
This was referenced Dec 4, 2024
Closed
Open
@lawrence-forooghian
Copy link
Collaborator Author

Created a spec issue for this ably/specification#254

lawrence-forooghian added a commit that referenced this issue Dec 4, 2024
@lawrence-forooghian
Rename Message.latestAction to action
25e3f41 
Upon our integration tests starting to fail, we noticed that Realtime
seems to have renamed the `latestAction` property to `action`. This
change has not yet been reflected in the spec, but has been in JS [1].

I’ve created an issue to get the spec updated [2] but since this test
failure is stopping us from merging anything else I am going to rename
this property until we get a more definitive answer.

Part of #169.

[1] ably/ably-chat-js#427
[2] ably/specification#254
lawrence-forooghian added a commit that referenced this issue Dec 4, 2024
@lawrence-forooghian
Introduce a wait to work around history not being “live”
e7e5e3b 
(The integration tests are still failing, though, due to #169, but at
least they’re now failing in a consistent manner.)

Resolves #167.
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maratal @lawrence-forooghian