Fix Ably-Agent usage #280
Merged
Fix Ably-Agent usage #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/280/typedoc
As per the agents.json: https://github.com/ably/ably-common/blob/fbcbc120bad41984443a089a66058d80f915dc7c/protocol/agents.json#L323-L327 Signed-off-by: Lewis Marshall <[email protected]>
It's no longer needed since a client is always passed to the constructor now. Signed-off-by: Lewis Marshall <[email protected]>
lmars
force-pushed
the
fix-ably-agent
branch
from
6fa6ac6 to
f2ffa87
Compare
dpiatek
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
nice one @lmars - we just need to update https://github.com/search?q=repo%3Aably%2Fably-common%20spaces&type=code now I think?
|
@dpiatek yep thanks, done in ably/ably-common#227. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spaces SDK needs only one Ably-Agent entry,
spaces, so this replaces the currentably-spaceswithspacesin theagentsclient options, and removes the unnecessaryspace-custom-cliententry.