Refactor space updates #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snikidev
reviewed
Sep 21, 2023
Comment on lines
9
to
+12
| import type { PresenceMember } from './utilities/types.js'; | ||
| import type Space from './Space.js'; | ||
| import { ERR_NOT_ENTERED_SPACE } from './Errors.js'; | ||
| import SpaceUpdate from './SpaceUpdate.js'; |
There was a problem hiding this comment.
I'm confused, why do imports have extensions? Is that normal?
There was a problem hiding this comment.
Have a look at this issue microsoft/TypeScript#16577 (comment) and our own here #76. .js extensions provide the widest compatibility when loading in different environments, after bundling.
snikidev
approved these changes
Sep 21, 2023
added 3 commits
September 22, 2023 09:56
This class is responsible for creating objects that will be passed to presence. It takes care of creating an update id and encapsulates the structure of the update.
dpiatek
force-pushed
the
refactor-space-update
branch
from
db8f16d to
221d988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors space updates so we have a single class responsible for managing the shape of the updates.
This also fixes:
updateProfileDatanot passing an argument to the update function (see @snikidev 's report).leaveresetting profileData for users when no arguments are passed in https://ably.atlassian.net/browse/MMB-303