-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Kotlin SDK development principle #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for adding me as a reviewer, will take a look once free 👍 |
umair-ably
reviewed
Aug 29, 2024
umair-ably
reviewed
Aug 29, 2024
umair-ably
reviewed
Aug 29, 2024
umair-ably
reviewed
Aug 29, 2024
umair-ably
reviewed
Aug 29, 2024
AndyTWF
reviewed
Sep 2, 2024
ttypic
force-pushed
the
tranfer-sdk-principles
branch
2 times, most recently
from
September 6, 2024 11:49
99b17a9
to
0a19569
Compare
ttypic
force-pushed
the
sdk-principles-kotlin
branch
from
September 6, 2024 12:27
8726232
to
f67b9a2
Compare
umair-ably
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
First version of Kotlin SDK development principles, outlining future improvements for the `ably-java` SDK and upcoming JVM SDKs for new products. Co-authored-by: Umair <[email protected]>
ttypic
force-pushed
the
sdk-principles-kotlin
branch
from
September 9, 2024 08:58
f67b9a2
to
98176fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of Kotlin SDK development principles, outlining future improvements for the
ably-java
SDK and upcoming JVM SDKs for new products.