Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the link to guidance on how to do Git commits #57

Merged
merged 2 commits into from
May 29, 2024

Conversation

lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented May 28, 2024

The linked Confluence pages give me a 404. Searching Confluence for "Git commit" gives me this page, which suggests that the canonical source for this data is actually the guidance that was added to this repo in ef8ac8f.

The linked Confluence pages give me a 404. Searching Confluence for "Git
commit" gives me [1], which suggests that the canonical source for this
data is actually the guidance that was added to this repo in ef8ac8f.

[1] https://ably.atlassian.net/wiki/x/eoChEg
Copy link

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suggested one more link update below of the same nature

best-practices/pull-requests.md Outdated Show resolved Hide resolved
The linked Confluence pages give me a 404. Searching Confluence for
"development flow" gives me [1], which suggests that the canonical
source for this data is actually the guidance that was added to this
repo in ef8ac8f.

[1] https://ably.atlassian.net/wiki/x/swCYEg
@lawrence-forooghian lawrence-forooghian merged commit 0dc805c into main May 29, 2024
1 check passed
@lawrence-forooghian lawrence-forooghian deleted the link-to-commit-guidance branch May 29, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants