Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the description of outboundBatchInterval to reflect last Spaces SDK changes #2262

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Change the description of outboundBatchInterval to reflect last Spaces SDK changes #2262

merged 1 commit into from
Sep 18, 2024

Conversation

JoaoDiasAbly
Copy link
Contributor

@ably-ci ably-ci temporarily deployed to ably-docs-feature-rea-1-j1nqze September 4, 2024 16:06 Inactive
@JoaoDiasAbly JoaoDiasAbly marked this pull request as ready for review September 6, 2024 13:03
paddybyers
paddybyers approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

m-hulbert
m-hulbert approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@m-hulbert m-hulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @JoaoDiasAbly

@m-hulbert m-hulbert added the Do not merge When the PR is in progress do not merge label Sep 12, 2024
@JoaoDiasAbly
Copy link
Contributor Author

@m-hulbert the related ticket has now been closed. Can we merge this PR? 😎

@m-hulbert m-hulbert removed the Do not merge When the PR is in progress do not merge label Sep 18, 2024
@m-hulbert m-hulbert merged commit 6228795 into main Sep 18, 2024
4 checks passed
@m-hulbert m-hulbert deleted the feature/REA-1868-cursors-batching branch September 18, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-hulbert m-hulbert m-hulbert approved these changes

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoaoDiasAbly @paddybyers @m-hulbert @ably-ci