Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-4082] Include example for input field prefix usage, rename poorly named icon #544

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[WEB-4082] Include example for input field prefix usage, rename poorly named icon #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d91ea0d
feat: include example for icon insert on input fields
jamiehenson Nov 14, 2024
1732e0a
chore: rename connection state icon to selector-friendly name
jamiehenson Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Icon/__snapshots__/Icon.stories.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,14 +447,14 @@ exports[`JS Components/Icon DisplayIcons smoke-test 1`] = `
</div>
<div class="border p-16 flex flex-col sm:flex-row items-center justify-between gap-12">
<code class="ui-text-code mb-8 block">
icon-display-connection-state-&amp;-recovery
icon-display-connection-state-recovery
</code>
<div class="border inline-flex flex-0">
<div class="flex pi-checkered-bg">
<svg class="text-cool-black hover:text-active-orange"
style="width: 1.5rem; height: 1.5rem;"
>
<use xlink:href="#sprite-icon-display-connection-state-&amp;-recovery">
<use xlink:href="#sprite-icon-display-connection-state-recovery">
</use>
</svg>
</div>
Expand Down
0 ...n-display-connection-state-&-recovery.svg → ...con-display-connection-state-recovery.svg
View file
Open in desktop
File renamed without changes
14 changes: 14 additions & 0 deletions src/core/styles/Forms.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,20 @@ export const Inputs = {
/>
<p className="ui-text-p3 text-gui-error-red mt-8">Oof, what an input</p>
</div>
<div>
<p className="mb-16 text-neutral-800">With character insert</p>
<div className="relative">
<div className="h-32 w-32 absolute left-8 top-8 flex items-center justify-center select-none cursor-default">
$
</div>
<input
type="search"
className="ui-input pl-40"
placeholder="With icon"
autoComplete="off"
/>
jamiehenson marked this conversation as resolved.
Show resolved Hide resolved
</div>
</div>
</div>
),
};
Expand Down
15 changes: 15 additions & 0 deletions src/core/styles/__snapshots__/Forms.stories.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,21 @@ exports[`CSS/Forms Inputs smoke-test 1`] = `
Oof, what an input
</p>
</div>
<div>
<p class="mb-16 text-neutral-800">
With character insert
</p>
<div class="relative">
<div class="h-32 w-32 absolute left-8 top-8 flex items-center justify-center select-none cursor-default">
$
</div>
<input type="search"
class="ui-input pl-40"
placeholder="With icon"
autocomplete="off"
>
</div>
</div>
</div>
`;

Expand Down
Loading