Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-4122] Remove Datadog Lite reference from PricingCards #542

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jamiehenson
Copy link
Member

@jamiehenson jamiehenson commented Nov 13, 2024

Jira Ticket Link / Motivation

Links to this ticket. Removing references to Datadog Lite until further notice.

Summary of changes

Screenshot 2024-11-13 at 15 56 01

How do you manually test this?

Reviewer Tasks (optional)

Merge/Deploy Checklist

  • Written automated tests for implemented features/fixed bugs
  • Rebased and squashed commits
  • Commits have clear descriptions of their changes
  • Checked for any performance regressions

Frontend Checklist

  • No frontend changes in this PR
  • Added before/after screenshots for changes
  • Tested on different platforms/browsers with Browserstack
  • Compared with the initial design / our brand guidelines
  • Checked the code for accessibility issues (VoiceOver User Guide)?

Summary by CodeRabbit

  • New Features

    • Updated version number to 14.7.9 for the project.
  • Bug Fixes

    • Removed "Datadog (lite)" from the features included in the "Pro" plan, streamlining the offered features.

Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

Walkthrough

The pull request includes an update to the package.json file for the @ably/ui project, changing the version number from 14.7.8 to 14.7.9. Additionally, in the src/core/Pricing/data.tsx file, the "Pro" plan's features have been modified by removing the item "Datadog (lite)" from the items array. No other changes were made to the structure or other elements of the files.

Changes

File Change Summary
package.json Updated version number from 14.7.8 to 14.7.9.
src/core/Pricing/data.tsx Removed "Datadog (lite)" from "Pro" plan features.

Assessment against linked issues

Objective Addressed Explanation
Update version number (WEB-4122)
Modify Pro plan features (WEB-4122)

Possibly related PRs

Suggested labels

review

Suggested reviewers

  • kennethkalmer

Poem

In the garden of code, we hop and play,
Version numbers change, brightening the day.
Features shift like leaves in the breeze,
With each little update, we aim to please!
So here’s to the changes, both big and small,
A joyful leap forward, we celebrate all! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 65dda18 and a4e8a42.

📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/core/Pricing/data.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json
🔇 Additional comments (2)
src/core/Pricing/data.tsx (2)

135-135: LGTM! Datadog Lite reference successfully removed.

The removal of Datadog Lite from the Pro plan's features aligns with the PR objectives.


135-135: Verify no other Datadog Lite references exist.

Let's ensure we've caught all instances of "Datadog Lite" in the codebase.

✅ Verification successful

No "Datadog Lite" references found in the codebase

After thorough verification across the codebase, there is only one reference to "Datadog" in src/core/Pricing/data.tsx, and it's not associated with "Lite". All other occurrences of "lite" or "light" are unrelated to Datadog (they're CSS/styling related). The codebase is clean from any remaining "Datadog Lite" references.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to Datadog Lite
rg -i "datadog.*(lite|light)" --type-add 'web:*.{tsx,ts,jsx,js}'

Length of output: 66


Script:

#!/bin/bash
# Let's try a broader search for "lite" or "light" in pricing-related files
rg -i "(lite|light)" src/core/Pricing/

# Also search for any Datadog references to be thorough
rg -i "datadog" src/core/Pricing/

Length of output: 588


Script:

#!/bin/bash
# Let's do one final broader search across the entire codebase
# to ensure we haven't missed any Datadog Lite references
rg -i "datadog" -A 2 -B 2

# Also search specifically in any configuration or documentation files
fd -e md -e json -e yaml -e yml -X rg -i "datadog"

Length of output: 340


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jamiehenson jamiehenson requested a review from a team November 13, 2024 15:59
@jamiehenson jamiehenson merged commit 44b39b8 into main Nov 13, 2024
4 checks passed
@jamiehenson jamiehenson deleted the remove-datadog-lite-from-pricing branch November 13, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants