Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update versions action #295

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix update versions action #295

merged 2 commits into from
Dec 5, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Nov 30, 2023

Fix update versions action which on release and updates the values of versions for the preview up and library https://github.com/ably/ably-ui/actions/runs/7061490420. This is separate to the releasing because it sometimes takes a while for ruby gems to update the package availability - so we do it as a separate step.

I've also updated update-dependents to properly fail if the curl fails. This doesn't work however, as we need to obtain a valid REGISTRY_TOKEN.

@ably-ci ably-ci temporarily deployed to ably-ui-fix-update-vers-usx5qs November 30, 2023 16:06 Inactive
@dpiatek dpiatek force-pushed the fix-update-versions-script branch from 799e124 to d17e510 Compare November 30, 2023 16:11
@dpiatek dpiatek temporarily deployed to ably-ui-fix-update-vers-usx5qs November 30, 2023 16:11 Inactive
@dpiatek dpiatek force-pushed the fix-update-versions-script branch from d17e510 to 5880762 Compare November 30, 2023 16:14
@dpiatek dpiatek temporarily deployed to ably-ui-fix-update-vers-usx5qs November 30, 2023 16:15 Inactive
@dpiatek dpiatek force-pushed the fix-update-versions-script branch from 5880762 to 3ea314c Compare November 30, 2023 16:22
@dpiatek dpiatek temporarily deployed to ably-ui-fix-update-vers-usx5qs November 30, 2023 16:23 Inactive
@dpiatek dpiatek temporarily deployed to ably-ui-fix-update-vers-usx5qs November 30, 2023 16:38 Inactive
@dpiatek dpiatek temporarily deployed to ably-ui-fix-update-vers-usx5qs December 1, 2023 14:42 Inactive
@dpiatek dpiatek force-pushed the fix-update-versions-script branch from 797a21f to 333041a Compare December 1, 2023 14:47
@dpiatek dpiatek force-pushed the fix-update-versions-script branch from 333041a to bd46e89 Compare December 1, 2023 14:47
@dpiatek dpiatek temporarily deployed to ably-ui-fix-update-vers-usx5qs December 1, 2023 14:47 Inactive
Copy link
Member

@kennethkalmer kennethkalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpiatek dpiatek merged commit ea9e7f6 into main Dec 5, 2023
3 checks passed
@dpiatek dpiatek deleted the fix-update-versions-script branch December 5, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants