Skip to content

Commit

Permalink
Merge pull request #292 from ably/act-86-new-sdk-page-link
Browse files Browse the repository at this point in the history
[ACT-86] Meganav and footer has new sdk page link
  • Loading branch information
denissellu authored Nov 15, 2023
2 parents fc789ca + b3d247d commit e331c66
Show file tree
Hide file tree
Showing 13 changed files with 2,126 additions and 1,755 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
ably-ui (8.7.0.dev.3453cca)
ably-ui (8.7.0.dev.827e917)
view_component (>= 2.33, < 2.50)

GEM
Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/core/footer/__snapshots__/snapshots.cy.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ exports[`Footer Snapshot Test > react > test case common to both #0`] = `
>
</li>
<li class="p-menu-row-snug">
<a href="/download" class="ui-footer-menu-row-link">SDKs</a>
<a href="/docs/sdks" class="ui-footer-menu-row-link">SDKs</a>
</li>
<li class="p-menu-row-snug flex items-center -mt-4">
<a
Expand Down Expand Up @@ -529,7 +529,7 @@ exports[`Footer Snapshot Test > view component > test case common to both #0`] =
>
</li>
<li class="p-menu-row-snug">
<a class="ui-footer-menu-row-link" href="/download">SDKs</a>
<a class="ui-footer-menu-row-link" href="/docs/sdks">SDKs</a>
</li>
<li class="p-menu-row-snug flex items-center -mt-4">
<a
Expand Down
2 changes: 1 addition & 1 deletion lib/ably_ui/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module AblyUi
VERSION = '8.7.0.dev.3453cca'
VERSION = '8.7.0.dev.827e917'
end
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ably/ui",
"version": "8.7.0-dev.3453cca",
"version": "8.7.0-dev.827e917",
"description": "Home of the Ably design system library ([design.ably.com](https://design.ably.com)). It provides a showcase, development/test environment and a publishing pipeline for different distributables.",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion preview/.tool-versions
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ruby 3.1.2
nodejs 14.15.4
nodejs 16.14.2
python 2.7.18
2 changes: 1 addition & 1 deletion preview/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ gem 'view_component', '~> 2.33.0', require: 'view_component/engine'

gem 'responders'

gem 'ably-ui', require: 'ably_ui'
gem 'ably-ui', '8.7.0.dev.827e917', require: 'ably_ui'

# https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias
gem 'psych', '< 4'
Expand Down
4 changes: 2 additions & 2 deletions preview/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
GEM
remote: https://rubygems.org/
specs:
ably-ui (11.7.0)
ably-ui (8.7.0.dev.827e917)
view_component (>= 2.33, < 2.50)
actioncable (6.0.5.1)
actionpack (= 6.0.5.1)
Expand Down Expand Up @@ -176,7 +176,7 @@ PLATFORMS
x86_64-linux

DEPENDENCIES
ably-ui
ably-ui (= 8.7.0.dev.827e917)
bootsnap (>= 1.4.2)
byebug
dotenv-rails
Expand Down
12 changes: 4 additions & 8 deletions preview/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@
"name": "preview",
"private": true,
"dependencies": {
"@ably/ui": "11.7.0",
"@ably/ui": "8.7.0-dev.827e917",
"@babel/preset-react": "^7.12.5",
"@rails/ujs": "^6.0.0",
"@rails/webpacker": "4.3.0",
"@rails/webpacker": "5.4.4",
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
"node-sass": "^7.0.0",
"postcss": "^7",
"prop-types": "^15.7.2",
"react": "^17.0.1",
Expand All @@ -16,16 +15,13 @@
"tailwindcss-filters": "^3.0.0"
},
"engines": {
"node": ">=12.16.1",
"yarn": ">=1.22.4"
"node": "^16.14.2",
"yarn": "^1.22.4"
},
"version": "0.1.0",
"devDependencies": {
"@tailwindcss/postcss7-compat": "^2.0.3",
"autoprefixer": "^9",
"webpack-dev-server": "^3.11.0"
},
"resolutions": {
"node-sass": "^6.0.1"
}
}
3,843 changes: 2,109 additions & 1,734 deletions preview/yarn.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/core/Footer/component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
<%= link_to 'Support & FAQs', abs_url("/support"), class: "ui-footer-menu-row-link" %>
</li>
<li class="p-menu-row-snug">
<%= link_to 'SDKs', abs_url("/download"), class: "ui-footer-menu-row-link" %>
<%= link_to 'SDKs', abs_url("/docs/sdks"), class: "ui-footer-menu-row-link" %>
</li>
<li class="p-menu-row-snug flex items-center -mt-4">
<a class="pr-8 ui-footer-menu-row-link" href="https://status.ably.com/">System status</a>
Expand Down
2 changes: 1 addition & 1 deletion src/core/Footer/component.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export default function Footer({ paths, urlBase }) {
</a>
</li>
<li className="p-menu-row-snug">
<a href={absUrl("/download")} className="ui-footer-menu-row-link">
<a href={absUrl("/docs/sdks")} className="ui-footer-menu-row-link">
SDKs
</a>
</li>
Expand Down
2 changes: 1 addition & 1 deletion src/core/MeganavContentDevelopers/component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<div class="col-span-full md:col-span-4 pb-8 md:py-24 lg:py-32 px-24 sm:px-32 md:px-0">
<ul class="md:mt-40" aria-labelledby="meganav-developers-panel-explore">
<li>
<%= link_to abs_url("/download"), class: "ui-meganav-media-with-image group" do %>
<%= link_to abs_url("/docs/sdks"), class: "ui-meganav-media-with-image group" do %>
<%= render(AblyUi::Core::Icon.new(name: "icon-display-sdks-col", size: "2.5rem")) %>
<div class="flex flex-col justify-center">
<p class="ui-meganav-media-heading">SDKs</p>
Expand Down
2 changes: 1 addition & 1 deletion src/core/MeganavContentDevelopers/component.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const MeganavContentDevelopers = ({ absUrl }) => (
<div className="col-span-full md:col-span-4 pb-8 md:py-24 lg:py-32 px-24 sm:px-32 md:px-0">
<ul className="md:mt-40" aria-labelledby="meganav-developers-panel-explore">
<li>
<a href={absUrl("/download")} className="ui-meganav-media-with-image group">
<a href={absUrl("/docs/sdks")} className="ui-meganav-media-with-image group">
<Icon name="icon-display-sdks-col" size="2.5rem" />
<div className="flex flex-col justify-center">
<p className="ui-meganav-media-heading">SDKs</p>
Expand Down

0 comments on commit e331c66

Please sign in to comment.