Skip to content

Commit

Permalink
chore: switch to using the StatusIcon component in meganav & footer
Browse files Browse the repository at this point in the history
For the meganav this resolves the issue of invalid markup (a > a)
  • Loading branch information
kennethkalmer committed Nov 25, 2024
1 parent 398c4a2 commit d0271c0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
10 changes: 6 additions & 4 deletions src/core/Footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from "react";

import Icon from "./Icon";
import _absUrl from "./url-base.js";
import Status from "./Status.js";
import { StatusIcon } from "./Status.js";

type FooterProps = {
paths: {
Expand Down Expand Up @@ -209,14 +209,16 @@ const Footer = ({ paths, urlBase, statusUrl }: FooterProps) => {
SDKs
</a>
</li>
<li className="p-menu-row-snug flex items-center -mt-4">
<li className="p-menu-row-snug">
<a
className="pr-8 ui-footer-menu-row-link"
className="ui-footer-menu-row-link flex items-center gap-4"
href="https://status.ably.com/"
target="_blank"
rel="noreferrer"
>
System status
<StatusIcon statusUrl={statusUrl} />
</a>
<Status statusUrl={statusUrl} />
</li>
</ul>
</div>
Expand Down
9 changes: 3 additions & 6 deletions src/core/MeganavContentDevelopers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from "react";

import Icon from "./Icon";
import { AbsUrl } from "./Meganav";
import Status from "./Status";
import { StatusIcon } from "./Status";

const MeganavContentDevelopers = ({
absUrl,
Expand Down Expand Up @@ -186,12 +186,9 @@ const MeganavContentDevelopers = ({
href="https://status.ably.com/"
className="group ui-meganav-media py-12"
>
<p className="ui-meganav-media-heading">
<p className="ui-meganav-media-heading flex items-center gap-4">
Status
<Status
statusUrl={statusUrl}
additionalCSS="ml-4 align-middle"
/>
<StatusIcon statusUrl={statusUrl} />
</p>
</a>
</li>
Expand Down

0 comments on commit d0271c0

Please sign in to comment.