Skip to content

Commit

Permalink
Merge pull request #283 from ably/WEB-3241-remove-hub-from-footer
Browse files Browse the repository at this point in the history
WEB-3241: Remove link to the hub page in footer
  • Loading branch information
Andrien authored Sep 15, 2023
2 parents c29ac5c + 2396c43 commit b11a6b9
Show file tree
Hide file tree
Showing 12 changed files with 18 additions and 54 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
ably-ui (8.7.0.dev.35edbd4)
ably-ui (8.7.0.dev.33117ed)
view_component (>= 2.33, < 2.50)

GEM
Expand Down
24 changes: 2 additions & 22 deletions cypress/integration/core/footer/__snapshots__/snapshots.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ exports[`Footer Snapshot Test > react > test case common to both #0`] = `
</div>
<ul class="grid grid-cols-1">
<li class="p-menu-row-snug">
<a href="/pub-sub-messaging" class="ui-footer-menu-row-link"
<a href="/solutions/channels" class="ui-footer-menu-row-link"
>Pub/sub messaging</a
>
</li>
Expand All @@ -43,11 +43,6 @@ exports[`Footer Snapshot Test > react > test case common to both #0`] = `
>Multiple protocol messaging</a
>
</li>
<li class="p-menu-row-snug">
<a href="/hub" class="ui-footer-menu-row-link"
>Streaming data sources</a
>
</li>
</ul>
</div>
<div class="col-span-full xs:col-span-3 md:col-span-1">
Expand Down Expand Up @@ -85,11 +80,6 @@ exports[`Footer Snapshot Test > react > test case common to both #0`] = `
>Healthcare</a
>
</li>
<li class="p-menu-row-snug">
<a href="/hub" class="ui-footer-menu-row-link"
>Streaming data sources</a
>
</li>
<li class="p-menu-row-snug">
<a
href="/solutions/ecommerce-and-retail"
Expand Down Expand Up @@ -430,7 +420,7 @@ exports[`Footer Snapshot Test > view component > test case common to both #0`] =
</div>
<ul class="grid grid-cols-1">
<li class="p-menu-row-snug">
<a class="ui-footer-menu-row-link" href="/pub-sub-messaging"
<a class="ui-footer-menu-row-link" href="/solutions/channels"
>Pub/sub messaging</a
>
</li>
Expand All @@ -449,11 +439,6 @@ exports[`Footer Snapshot Test > view component > test case common to both #0`] =
>Multiple protocol messaging</a
>
</li>
<li class="p-menu-row-snug">
<a class="ui-footer-menu-row-link" href="/hub"
>Streaming data sources</a
>
</li>
</ul>
</div>
<div class="col-span-full xs:col-span-3 md:col-span-1">
Expand Down Expand Up @@ -491,11 +476,6 @@ exports[`Footer Snapshot Test > view component > test case common to both #0`] =
>Healthcare</a
>
</li>
<li class="p-menu-row-snug">
<a class="ui-footer-menu-row-link" href="/hub"
>Streaming data sources</a
>
</li>
<li class="p-menu-row-snug">
<a
class="ui-footer-menu-row-link"
Expand Down
4 changes: 2 additions & 2 deletions cypress/integration/core/meganav/parity.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ describe("Panels", () => {

describe("PlatformPanel", () => {
it("looks the same on desktop", () =>
cy.compareComponents(config("Platform", "desktop")));
cy.compareComponents(config("Products", "desktop")));

it("looks the same on mobile", () =>
cy.compareComponents(config("Platform", "mobile")));
cy.compareComponents(config("Products", "mobile")));
});

describe("DevelopersPanel", () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/ably_ui/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module AblyUi
VERSION = '8.7.0.dev.35edbd4'
VERSION = '8.7.0.dev.33117ed'
end
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ably/ui",
"version": "8.7.0-dev.35edbd4",
"version": "8.7.0-dev.33117ed",
"description": "Home of the Ably design system library ([design.ably.com](https://design.ably.com)). It provides a showcase, development/test environment and a publishing pipeline for different distributables.",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion preview/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ gem 'view_component', '~> 2.33.0', require: 'view_component/engine'

gem 'responders'

gem 'ably-ui', '8.7.0.dev.35edbd4', require: 'ably_ui'
gem 'ably-ui', '8.7.0.dev.33117ed', require: 'ably_ui'

# https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias
gem 'psych', '< 4'
Expand Down
4 changes: 2 additions & 2 deletions preview/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
GEM
remote: https://rubygems.org/
specs:
ably-ui (8.7.0.dev.35edbd4)
ably-ui (8.7.0.dev.33117ed)
view_component (>= 2.33, < 2.50)
actioncable (6.0.5.1)
actionpack (= 6.0.5.1)
Expand Down Expand Up @@ -175,7 +175,7 @@ PLATFORMS
x86_64-linux

DEPENDENCIES
ably-ui (= 8.7.0.dev.35edbd4)
ably-ui (= 8.7.0.dev.33117ed)
bootsnap (>= 1.4.2)
byebug
dotenv-rails
Expand Down
2 changes: 1 addition & 1 deletion preview/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "preview",
"private": true,
"dependencies": {
"@ably/ui": "8.7.0-dev.35edbd4",
"@ably/ui": "8.7.0-dev.33117ed",
"@babel/preset-react": "^7.12.5",
"@rails/ujs": "^6.0.0",
"@rails/webpacker": "4.3.0",
Expand Down
8 changes: 4 additions & 4 deletions preview/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# yarn lockfile v1


"@ably/[email protected].35edbd4":
version "8.7.0-dev.35edbd4"
resolved "https://registry.yarnpkg.com/@ably/ui/-/ui-8.7.0-dev.35edbd4.tgz#18f0f156493dafdf4816c8f24ea9e6fe5c75b97c"
integrity sha512-LQCdob5I0te/xi5Jcx9p8MdJuwRMcAeCLeenwSpu8Zardr40SO89n1U6NwsFvMOvJcoTKPsE077RJ96/za768A==
"@ably/[email protected].33117ed":
version "8.7.0-dev.33117ed"
resolved "https://registry.yarnpkg.com/@ably/ui/-/ui-8.7.0-dev.33117ed.tgz#5e6bce959d1f36a4a7287b0ab5d8ad0cf8607560"
integrity sha512-LGSwb1dfw7HRlvUJfcgtavW03wXLfE1/ktvLsLI+9Y9WNKHvtsBY2sw0VikhrBQqkfKWNxnZ3i9TJu4gUiqYLQ==
dependencies:
addsearch-js-client "^0.7.0"
array-flat-polyfill "^1.0.1"
Expand Down
8 changes: 1 addition & 7 deletions src/core/Footer/component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</div>
<ul class="grid grid-cols-1">
<li class="p-menu-row-snug">
<%= link_to 'Pub/sub messaging', abs_url("/pub-sub-messaging"), class: "ui-footer-menu-row-link" %>
<%= link_to 'Pub/sub messaging', abs_url("/solutions/channels"), class: "ui-footer-menu-row-link" %>
</li>
<li class="p-menu-row-snug">
<%= link_to 'Push notifications', abs_url("/push-notifications"), class: "ui-footer-menu-row-link" %>
Expand All @@ -23,9 +23,6 @@
<li class="p-menu-row-snug">
<%= link_to 'Multiple protocol messaging', abs_url("/protocols"), class: "ui-footer-menu-row-link" %>
</li>
<li class="p-menu-row-snug">
<%= link_to 'Streaming data sources', abs_url("/hub"), class: "ui-footer-menu-row-link" %>
</li>
</ul>
</div>
<div class="col-span-full xs:col-span-3 md:col-span-1">
Expand All @@ -49,9 +46,6 @@
<li class="p-menu-row-snug">
<%= link_to 'Healthcare', abs_url("/solutions/healthcare"), class: "ui-footer-menu-row-link" %>
</li>
<li class="p-menu-row-snug">
<%= link_to 'Streaming data sources', abs_url("/hub"), class: "ui-footer-menu-row-link" %>
</li>
<li class="p-menu-row-snug">
<%= link_to 'eCommerce & Retail', abs_url("/solutions/ecommerce-and-retail"), class: "ui-footer-menu-row-link" %>
</li>
Expand Down
12 changes: 1 addition & 11 deletions src/core/Footer/component.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default function Footer({ paths, urlBase }) {

<ul className="grid grid-cols-1">
<li className="p-menu-row-snug">
<a href={absUrl("/pub-sub-messaging")} className="ui-footer-menu-row-link">
<a href={absUrl("/solutions/channels")} className="ui-footer-menu-row-link">
Pub/sub messaging
</a>
</li>
Expand All @@ -42,11 +42,6 @@ export default function Footer({ paths, urlBase }) {
Multiple protocol messaging
</a>
</li>
<li className="p-menu-row-snug">
<a href={absUrl("/hub")} className="ui-footer-menu-row-link">
Streaming data sources
</a>
</li>
</ul>
</div>

Expand Down Expand Up @@ -83,11 +78,6 @@ export default function Footer({ paths, urlBase }) {
Healthcare
</a>
</li>
<li className="p-menu-row-snug">
<a href={absUrl("/hub")} className="ui-footer-menu-row-link">
Streaming data sources
</a>
</li>
<li className="p-menu-row-snug">
<a href={absUrl("/solutions/ecommerce-and-retail")} className="ui-footer-menu-row-link">
eCommerce &amp; Retail
Expand Down
2 changes: 1 addition & 1 deletion src/core/MeganavContentProducts/component.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const MeganavContentProducts = ({ paths, absUrl }) => (

<div className="col-span-full md:col-span-4 pt-8 pb-24 md:py-24 lg:py-32 px-24 sm:px-32 md:px-0 bg-white">
<h3 className="ui-meganav-overline" id="meganav-products-panel-list-our-technology">
Our technology
Technology
</h3>
<ul className="mb-16" aria-labelledby="meganav-products-panel-list-our-technology">
<li>
Expand Down

0 comments on commit b11a6b9

Please sign in to comment.